Skip to content

Commit a9b7adc

Browse files
committed
Adding back some helpful comments
1 parent 37cc87f commit a9b7adc

1 file changed

Lines changed: 8 additions & 2 deletions

File tree

GPU/GPUTracking/Base/cuda/GPUReconstructionCUDA.cu

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -655,14 +655,20 @@ void GPUReconstructionCUDA::SetONNXGPUStream(Ort::SessionOptions& sessionOptions
655655
// CUDA is the fallback for nodes unsupported by TensorRT.
656656
OrtCUDAProviderOptionsV2* cudaOptions = nullptr;
657657
ORTCHK(api->CreateCUDAProviderOptions(&cudaOptions));
658+
// std::vector<const char*> keys{"device_id", "gpu_mem_limit", "arena_extend_strategy", "cudnn_conv_algo_search", "do_copy_in_default_stream", "cudnn_conv_use_max_workspace", "cudnn_conv1d_pad_to_nc1d"};
659+
// std::vector<const char*> values{"0", "2147483648", "kSameAsRequested", "DEFAULT", "1", "1", "1"};
660+
// UpdateCUDAProviderOptions(cuda_options, keys.data(), values.data(), keys.size());
658661
ORTCHK(api->UpdateCUDAProviderOptionsWithValue(cudaOptions, "user_compute_stream", mInternals->Streams[stream]));
659662
ORTCHK(api->SessionOptionsAppendExecutionProvider_CUDA_V2(sessionOptions, cudaOptions));
660663
api->ReleaseCUDAProviderOptions(cudaOptions);
661664

662665
#elif defined(ORT_ROCM_BUILD)
666+
// const auto& api = Ort::GetApi();
667+
// api.GetCurrentGpuDeviceId(deviceId);
663668
OrtROCMProviderOptions rocmOptions;
664-
rocmOptions.has_user_compute_stream = 1;
665-
rocmOptions.arena_extend_strategy = 0;
669+
rocmOptions.has_user_compute_stream = 1; // Indicate that we are passing a user stream
670+
rocmOptions.arena_extend_strategy = 0; // kNextPowerOfTwo = 0, kSameAsRequested = 1 -> https://github.com/search?q=repo%3Amicrosoft%2Fonnxruntime%20kSameAsRequested&type=code
671+
// rocm_options.gpu_mem_limit = 1073741824; // 0 means no limit
666672
rocmOptions.user_compute_stream = mInternals->Streams[stream];
667673
sessionOptions.AppendExecutionProvider_ROCM(rocmOptions);
668674
#endif

0 commit comments

Comments
 (0)