Java: Lighting values are not recalculated

[MrManiac3]

When cutting a large object and pasting it somewhere else, the lighting doesn't update with the blocks. This happens with all light levels, from dark to light. Placing blocks and removing them where the lighting issues occur sometimes updates the light levels to reflect the new block placement, but not always.

I noticed someone else had lighting issues in issue #8 but this is with a different context. I also noticed in a comment on that issue that lighting calculations currently aren't done, but I wanted to put it to paper here.

[gentlegiantJGC]

Amulet-Team/Amulet-Core/pull/121 partially fixes this.
This is still an issue before 1.14

[gentlegiantJGC]

I thought I had fixed this for 1.14+ worlds but apparently not.
I thought the game recalculated lighting if it was not defined in the chunk which is partially true but it does not propagate the light from light emitting blocks.

Option 1) Leave it as it is and let the game recalculate the lighting. Light emitting blocks will look weird.
Option 1a) Change the chunk status to force the lighting calculations. This will also run the spawn and heightmaps stages. One of which might be bad and the other good.
Option 2) Revert it to the old behaviour. Light values are not modified. This looks fine when adding blocks but weird when removing them.
Option 3) The proper solution (but would require a lot of work) is to fully recalculate the light. This would mean knowing the amount of light each block outputs/absorbs which as far as I know isn't readily available. This solution would also need to scale to modded worlds and future versions so a hard coded database is not ideal.

[atmos6767]

The bug still exists, and is quite annoying when copy-pasting large objects, especially closed rooms. The inside of a completely closed chamber is bright as if there's direct sunlight emitting. Removing and replacing a block in that area sometimes solves the issue, but not always.
However, converting the world from java to bedrock edition, and then reconverting it to java solves this problem. I used MCCToolChestPE to convert my world.
Though the lighting value seems to be recalculated, other problems such as all door hinges being reset to right side, or chain directions being reset to vertical happened.

[aboothered]

The bug still exists, and is quite annoying when copy-pasting large objects, especially closed rooms. The inside of a completely closed chamber is bright as if there's direct sunlight emitting. Removing and replacing a block in that area sometimes solves the issue, but not always.
However, converting the world from java to bedrock edition, and then reconverting it to java solves this problem. I used MCCToolChestPE to convert my world.
Though the lighting value seems to be recalculated, other problems such as all door hinges being reset to right side, or chain directions being reset to vertical happened.

@atmos6767
I was about to post an issue about the lighting bugs on 1.13 version and below, so it is really good I came across your post :]
Do you reckon the world might get corrupted in some way other than the ones you mentioned when converting it to and from bedrock?