feat: adding artifact streaming to the AKSNodeClass rather than Defaulting to true always #1205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bryce-Soghigian
force-pushed
the
bsoghigian/support-artifact-streaming
branch
from
23bf7db to
f6a1152
Compare
tallaxes
reviewed
Oct 9, 2025
Comment on lines
+90
to
+92
| // +kubebuilder:default=false | ||
| // +optional | ||
| ArtifactStreamingEnabled *bool `json:"artifactStreamingEnabled,omitempty"` |
Collaborator
There was a problem hiding this comment.
Shouldn't this require bumping AKSNodeClass hash version? Otherwise I think the presence of default means hash value will change and cause drift of all nodes ... In any case, aksnodeclass_hash_tests needs to be updated (seems to be missing coverage of some other fields as well)
3 tasks
|
Hey @tallaxes @Bryce-Soghigian, any plans to merge this one? I'm willing to help if needed. |
Contributor
Author
|
Had to move this from my branch to my fork |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
How was this change tested?
Does this change impact docs?
Release Note