feat(NodeClass): add option to configure patch settings #1232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a configuration option to the NodeClass CRD to control the Linux VM patch settings. xref: https://learn.microsoft.com/en-us/azure/virtual-machines/automatic-vm-guest-patching This setting is useful for enabling automatic patching on the provisioned node, which is required by many compliance frameworks to improve the security posture of VMs. Note that the field on the NodeClass spec is `Patching` rather than `PatchSettings`, which would more closely match the upstream library. My thinking is that this is less confusing than having fields suffixed with various forms of `settings`, `options`, `config`, etc. Also, this naming aligns with how the `Security` field drops the `Profile` suffix. Signed-off-by: squat <[email protected]>
Author
|
@microsoft-github-policy-service agree |
Signed-off-by: squat <[email protected]>
squat
force-pushed
the
add_vm_patch_settings_to_node_class
branch
from
413b1fe to
23903d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a configuration option to the NodeClass CRD to
control the Linux VM patch settings.
xref: https://learn.microsoft.com/en-us/azure/virtual-machines/automatic-vm-guest-patching
This setting is useful for enabling automatic patching on the
provisioned node, which is required by many compliance frameworks to
improve the security posture of VMs.
Note that the field on the NodeClass spec is
Patchingrather thanPatchSettings, which would more closely match the upstream library.My thinking is that this is less confusing than having fields suffixed
with various forms of
settings,options,config, etc. Also, thisnaming aligns with how the
Securityfield drops theProfilesuffix.Signed-off-by: squat [email protected]