Skip to content

Navigation Menu

Appearance settings

GitHub Copilot
Write better code with AI

GitHub Spark New
Build and deploy intelligent apps

GitHub Models New
Manage and compare prompts

GitHub Advanced Security
Find and fix vulnerabilities

Actions
Automate any workflow
Codespaces
Instant dev environments

Issues
Plan and track work

Code Review
Manage code changes

Discussions
Collaborate outside of code

Code Search
Find more, search less
Explore

Why GitHub

Documentation

GitHub Skills

Blog
Integrations

GitHub Marketplace

MCP Registry
View all features
By company size

Enterprises

Small and medium teams

Startups

Nonprofits
By use case

App Modernization

DevSecOps

DevOps

CI/CD

View all use cases
By industry

Healthcare

Financial services

Manufacturing

Government

View all industries
View all solutions
Topics

AI

DevOps

Security

Software Development

View all
Explore

Learning Pathways

Events & Webinars

Ebooks & Whitepapers

Customer Stories

Partners

Executive Insights
GitHub Sponsors
Fund open source developers
The ReadME Project
GitHub community articles
Repositories

Topics

Trending

Collections
Enterprise platform
AI-powered developer platform
Available add-ons

GitHub Advanced Security
Enterprise-grade security features

Copilot for business
Enterprise-grade AI features

Premium Support
Enterprise-grade 24/7 support
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

Azure / karpenter-provider-azure Public

Notifications You must be signed in to change notification settings
Fork 100
Star 516

Code
Issues 58
Pull requests 70
Actions
Projects
Models
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Projects
Models
Security
Insights

[CRD change] Add LocalDNSProfile to AKSNodeClassSpec + NAP Integration Tests#1233

Open

saewoni wants to merge 108 commits intomainAzure/karpenter-provider-azure:mainfrom

sakwa/localdns_for_NAPAzure/karpenter-provider-azure:sakwa/localdns_for_NAPCopy head branch name to clipboard

Conversation Commits108 (108)Checks Files changed

Open

[CRD change] Add LocalDNSProfile to AKSNodeClassSpec + NAP Integration Tests#1233
saewoni wants to merge 108 commits intomainfrom
sakwa/localdns_for_NAP

Commits

Commits on Dec 5, 2025

address ST1003: struct field CpuLimitInMilliCores should be CPULimitInMilliCores (stylecheck)
saewoni
committed
move back fips where it was
saewoni
committed
after make presubmit
saewoni
committed
copy over localdns-related code to v1beta1
saewoni
committed
files after doing make presubmit
saewoni
committed
hash test update
saewoni
committed
add crd validation cel tests
saewoni
committed
Update pkg/apis/v1alpha2/aksnodeclass.go

saewoni
and
Copilot
committed
Convert LocalDNS enums from int32 to string for better UX
saewoni
committed
this is not right but pushing changes after doing make presubmit, after pr comment addressing
saewoni
committed
revert pricing
saewoni
committed
delete LocalDNSState from CRD
saewoni
committed
added localdns to pkg/provisionclients/swagger/nodebootstrapping.json and then ran make az-swagger-generate-clients
saewoni
committed
plumb localdns from resolver.go -> image family's CustomScriptsNodeBootstrapping -> provisionclientbootstrap.go
saewoni
committed
add localdns integration tests
saewoni
committed
add localdns integration test
saewoni
committed
change seconds from int to nillableduration
saewoni
committed
use NillableDuration for duration fields, and update UTs
saewoni
committed
update utils.go to contain localdns model conversion logic, add time.duration -> seconds conversion, add utils_test
saewoni
committed
move localdns_test.go from test/suites/integration/localdns_test.go -> test/suites/localdns/localdns_test.go for testing and made test/suites/localdns/suite_test.go
saewoni
committed
move the localdns test back to test/suites/integration
saewoni
committed
use fmt.sprintf()
saewoni
committed
update the comments
saewoni
committed
more testing debugging logs
saewoni
committed
update test
saewoni
committed
update localdns_test to separate label check and dns resolution check in separate test cases
saewoni
committed
update dnsUtilsImage to mcr.microsoft.com/aks/devinfra/base-os-runtime-dnsutils:master.251024.1
saewoni
committed
using registry.k8s.io/e2e-test-images/agnhost:2.39 image and using dig +short +identify
saewoni
committed
remove unused functions
saewoni
committed
add sleep to other test being run
saewoni
committed
pass the image in PodOptions instead of Container
saewoni
committed
update logs in testing
saewoni
committed
add taints to the pods to wait for node to be ready
saewoni
committed
add CriticalAddonsOnly taint toleration
saewoni
committed
added {Key: node.cloudprovider.kubernetes.io/uninitialized, Operator: corev1.TolerationOpExists, Effect: corev1.TaintEffectNoSchedule} to all test pods
saewoni
committed
remove criticaladdonsonly taint tolerance
saewoni
committed
add node selector on pods
saewoni
committed
add debugging in provisionclientbootstrap
saewoni
committed
add cse script log
saewoni
committed
change the nodeSelector, since testing.karpenter.sh/test-id uses karpenter.sh, which is restricted by karpenter's validation
saewoni
committed
simplify the nodeSelector key-val pair since it errored out again
saewoni
committed
add more logging to pkg/provisionclients/client/operations/operations_client.go and pkg/providers/imagefamily/customscriptsbootstrap/provisionclientbootstrap.go
saewoni
committed
add CriticalAddonsOnly taint toleration to all new nodes
saewoni
committed
add another test with full localdns config
saewoni
committed
Add LocalDNS State field and validation tests
saewoni
committed
revert commit 86fef1bdb2ff253f73afc803b5d9d241fb02a5bc
saewoni
committed
revert commit 248d92e9dc82cba5b38be6eee36a7f472d1c4e2d
saewoni
committed
Revert "Add LocalDNS State field and validation tests"
saewoni
committed
add logging in pkg/providers/instance/vminstance.go to log result after doing createNetworkInterface and createVirtualMachine in beginLaunchInstance function
saewoni
committed
remove result.Poller from logging, which caused panic
saewoni
committed
rebase w latest main
saewoni
committed
add more localdns cel validation + add IsLocalDNSEnabled() to determine if LocalDNS should be enabled based on mode and k8s version (>= 1.36 for Preferred)
saewoni
committed
generated charts after editing aksnodeclass.go in v1beta1
saewoni
committed
add localdnsready status condition
saewoni
committed
implement localdns validation reconciler. implements the actual validation logic moved from CEL to runtime validation
saewoni
committed
add IsLocalDNSEnabled and add min/max for num of dnsOverrides properties
saewoni
committed
remove expensive xvalidation
saewoni
committed
use helper function to set the localdns label
saewoni
committed
filter instance types based on LocalDNS SKU requirements
saewoni
committed
add localdns reconciler test
saewoni
committed
sku test
saewoni
committed
updated CRDs
saewoni
committed
clean up localdns test
saewoni
committed
undo/delete localdns reconciler logic
saewoni
committed
remove LocalDNSREady from aksnodeclass_status files and related files
saewoni
committed
revert the log commit
saewoni
committed
remove commented out tests from localdns_test.go, and update the happy path test
saewoni
committed
removed simple test
saewoni
committed
remove nodeClass declaration from my test
saewoni
committed
update label setting logic
saewoni
committed
update cel validation test to assert on error message
saewoni
committed
combine should reject tests into a single table test
saewoni
committed
create host-network busybox pod on the node to do dns resolution on the node
saewoni
committed
delete als=als
saewoni
committed
make LocalDNS as all-or-nothing property under AKSNodeClassSpec
saewoni
committed
still working on cel validation
saewoni
committed
file changes after extensive CEL validation
saewoni
committed
remove maxproperties since we dont have that in the internal repo / docs
saewoni
committed
copy over tests from beta
saewoni
committed
localdns does not support ubuntu 2004
saewoni
committed
cap the overrides map to be at 10
saewoni
committed
update cel test with maxproperties validation
saewoni
committed
Revert "update cel test with maxproperties validation"
saewoni
committed
Revert "cap the overrides map to be at 10"
saewoni
committed
remove regex validation for localdns
saewoni
committed
removed cel validation tests following removing regex validation test on the zone names
saewoni
committed
moved regex validation to runtime validation, controllers/nodeclass/status/localdns_test.go
saewoni
committed
add localdns to the controller's reconciler logic, set localdnsready in pkg/test/nodeclass.go ApplyDefaultStatus function
saewoni
committed
remove sleep from the integration test, update the dns resolution for inflate pod
saewoni
committed
comment out standard dns ips for now
saewoni
committed
add back sleep
saewoni
committed

Commits on Dec 6, 2025

change from env.ExpectCreatedNodeCount -> env.EventuallyExpectCreatedNodeCount
saewoni
committed
happy path works!
saewoni
committed
update servestate from pointer to nonpointer
saewoni
committed
add omitempty for MaxConcurrent
saewoni
committed
update ForwardPolicy from pointer to non-pointer
saewoni
committed
update forwarddestination
saewoni
committed
update mode from pointer to nonpointer
saewoni
committed
update localdnsprotocol from pointer -> nonpointer
saewoni
committed
update querylogging
saewoni
committed
convert overrides from map to list type, tests still need work
saewoni
committed
update tests after dnsoverrides change
saewoni
committed
make changes for reconcile logic and remove cel validation for overrides
saewoni
committed

Commits on Dec 7, 2025

reduce CEL validation and increase localdns controller x reconciler validation
saewoni
committed
update the crd and update the hash test
saewoni
committed
include ISLocalDNSEnabled in p.instanceTypesCache.Get's key
saewoni
committed
localdns -> validation controller
saewoni
committed
remove node cordoning and refactor test
saewoni
committed

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Community
Docs
Contact

You can’t perform that action at this time.