feat: Add kubernetes.azure.com/scalesetpriority to WellKnownLabels #1284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tallaxes
approved these changes
Dec 4, 2025
matthchr
commented
Dec 4, 2025
| v1beta1.LabelSKUStoragePremiumCapable: "true", | ||
| v1beta1.LabelSKUStorageEphemeralOSMaxSize: "53", | ||
| v1beta1.AKSLabelCluster: env.NodeResourceGroup, | ||
| v1beta1.AKSLabelScaleSetPriority: "regular", |
Member
Author
There was a problem hiding this comment.
We need to test on spot as well. I am not sure we ever actually write spot... just regular above. We likely need a place where we conditionally write spot onto the node too.
Member
Author
There was a problem hiding this comment.
Also need to make sure that if I set up a NodePool with only this requirement, I end up getting all spot nodes, which I don't think I will here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How was this change tested?
Does this change impact docs?
Release Note