Skip to content

Commit ea6cc7c

Browse files
committed
fix: code smell
1 parent 9dd3a36 commit ea6cc7c

File tree

4 files changed

+8
-12
lines changed

4 files changed

+8
-12
lines changed

eslint.config.mjs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ export default [
5050
},
5151

5252
rules: {
53+
curly: ['error', 'multi'],
5354
'simple-import-sort/imports': 'error',
5455
'simple-import-sort/exports': 'error',
5556
'unicorn/filename-case': 'off',

src/commandLine.ts

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -106,9 +106,8 @@ function parseArguments(): ICopyFilesArguments {
106106
break;
107107
case 'cachetime':
108108
result.cachetime = Number.parseInt(value, 10);
109-
if (Number.isNaN(result.cachetime)) {
110-
throw new TypeError(`Invalid cachetime: ${value}`);
111-
}
109+
if (Number.isNaN(result.cachetime)) throw new TypeError(`Invalid cachetime: ${value}`);
110+
112111
break;
113112
default:
114113
throw new Error(`Unknown flag: ${flag}`);
@@ -190,9 +189,8 @@ function parseArguments(): ICopyFilesArguments {
190189
break;
191190
case 'cachetime':
192191
result.cachetime = Number.parseInt(nextArgument, 10);
193-
if (Number.isNaN(result.cachetime)) {
194-
throw new TypeError(`Invalid cachetime: ${nextArgument}`);
195-
}
192+
if (Number.isNaN(result.cachetime)) throw new TypeError(`Invalid cachetime: ${nextArgument}`);
193+
196194
index++;
197195
break;
198196
default:

test/fixtures/sample-files/script.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,5 @@ console.log('Hello from ESP32!');
22

33
document.addEventListener('DOMContentLoaded', () => {
44
const heading = document.querySelector('h1');
5-
if (heading) {
6-
heading.style.color = '#007bff';
7-
}
5+
if (heading) heading.style.color = '#007bff';
86
});

test/unit/file.test.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -87,9 +87,8 @@ describe('file', () => {
8787
vi.mocked(tinyglobby.globSync).mockReturnValue(mockFiles);
8888
vi.mocked(fs.readFileSync).mockImplementation((filePath: fs.PathOrFileDescriptor) => {
8989
const pathString = filePath.toString();
90-
if (pathString.includes('file1') || pathString.includes('file2')) {
91-
return content1;
92-
}
90+
if (pathString.includes('file1') || pathString.includes('file2')) return content1;
91+
9392
return content3;
9493
});
9594

0 commit comments

Comments
 (0)