fix(otlp/http): return expected protobuf (#254)

* fix(otlp/http): return expected protobuf

* rn

Author: mabdinur

ddapm_test_agent/agent.py

@@ -39,7 +39,9 @@
 from grpc import aio as grpc_aio
 from msgpack.exceptions import ExtraData as MsgPackExtraDataException
 from multidict import CIMultiDict
+from opentelemetry.proto.collector.logs.v1.logs_service_pb2 import ExportLogsServiceResponse
 from opentelemetry.proto.collector.logs.v1.logs_service_pb2_grpc import add_LogsServiceServicer_to_server
+from opentelemetry.proto.collector.metrics.v1.metrics_service_pb2 import ExportMetricsServiceResponse
 from opentelemetry.proto.collector.metrics.v1.metrics_service_pb2_grpc import add_MetricsServiceServicer_to_server
 
 from . import _get_version
@@ -724,7 +726,9 @@ async def handle_v1_logs(self, request: Request) -> web.Response:
             num_resource_logs,
             total_log_records,
         )
-        return web.HTTPOk()
+        return web.Response(
+            body=ExportLogsServiceResponse().SerializeToString(), status=200, content_type="application/x-protobuf"
+        )
 
     async def handle_v1_metrics(self, request: Request) -> web.Response:
         metrics_data = self._decode_v1_metrics(request)
@@ -739,7 +743,9 @@ async def handle_v1_metrics(self, request: Request) -> web.Response:
             num_resource_metrics,
             total_metrics,
         )
-        return web.HTTPOk()
+        return web.Response(
+            body=ExportMetricsServiceResponse().SerializeToString(), status=200, content_type="application/x-protobuf"
+        )
 
     async def handle_v07_remoteconfig(self, request: Request) -> web.Response:
         """Emulates Remote Config endpoint: /v0.7/config"""

releasenotes/notes/fix-otlp-endpoint-response-type-18822a3ac85e1cb7.yaml

@@ -0,0 +1,4 @@
+---
+fixes:
+  - |
+    otlp: Fix OTLP endpoint response format for logs and metrics to return proper protobuf content type and serialized response body for HTTP requests.

tests/test_logs.py

@@ -3,6 +3,7 @@
 
 from google.protobuf.json_format import MessageToDict
 from opentelemetry.proto.collector.logs.v1.logs_service_pb2 import ExportLogsServiceRequest
+from opentelemetry.proto.collector.logs.v1.logs_service_pb2 import ExportLogsServiceResponse
 from opentelemetry.proto.common.v1.common_pb2 import AnyValue
 from opentelemetry.proto.common.v1.common_pb2 import KeyValue
 from opentelemetry.proto.logs.v1.logs_pb2 import LogRecord
@@ -86,6 +87,9 @@ def otlp_logs_json(otlp_logs_protobuf):
 async def test_logs_endpoint_basic_http(testagent, otlp_http_url, otlp_logs_string, loop):
     resp = await testagent.post(f"{otlp_http_url}{LOGS_ENDPOINT}", headers=PROTOBUF_HEADERS, data=otlp_logs_string)
     assert resp.status == 200
+    assert resp.content_type == "application/x-protobuf"
+    body = await resp.read()
+    assert body == ExportLogsServiceResponse().SerializeToString()
 
 
 @pytest.mark.parametrize(

tests/test_metrics.py

@@ -3,6 +3,7 @@
 
 from google.protobuf.json_format import MessageToDict
 from opentelemetry.proto.collector.metrics.v1.metrics_service_pb2 import ExportMetricsServiceRequest
+from opentelemetry.proto.collector.metrics.v1.metrics_service_pb2 import ExportMetricsServiceResponse
 from opentelemetry.proto.common.v1.common_pb2 import AnyValue
 from opentelemetry.proto.common.v1.common_pb2 import KeyValue
 from opentelemetry.proto.metrics.v1.metrics_pb2 import AggregationTemporality
@@ -191,6 +192,9 @@ async def test_metrics_endpoint_basic_http(testagent, otlp_http_url, otlp_metric
         f"{otlp_http_url}{METRICS_ENDPOINT}", headers=PROTOBUF_HEADERS, data=otlp_metrics_string
     )
     assert resp.status == 200
+    assert resp.content_type == "application/x-protobuf"
+    body = await resp.read()
+    assert body == ExportMetricsServiceResponse().SerializeToString()
 
 
 @pytest.mark.parametrize(