Skip to content

Conversation

@bric3
Copy link
Contributor

@bric3 bric3 commented Nov 28, 2025

By default, the version remains test however when the environment variable TEST_AGENT_VERSION is passed the agent will use this value.

$ TEST_AGENT_VERSION="1.2.3" python3.12 -m ddapm_test_agent.agent
curl http://127.0.0.1:8126/info

with docker

$ docker build -t dd-apm-test-agent:local .
$ docker run --rm -d --name test-agent -p 8126\
    -e TEST_AGENT_VERSION="1.2.3" \
    dd-apm-test-agent:local
$ curl -s http://localhost:8126/info

@bric3 bric3 requested a review from cbeauchesne November 28, 2025 09:25
Copy link

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legit !

I'd also like to have @Kyle-Verhoog opinion of the env var name, as it'll spread in system-tests.

Copy link
Member

@Kyle-Verhoog Kyle-Verhoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! might be worth having a simple regression test so that we don't accidentally remove/change this feature but i'm good either way

@cbeauchesne
Copy link

cbeauchesne commented Dec 1, 2025

Well, as system-tests will use it, we'll have a (slightly painful) way of being alerted 😄

@bric3
Copy link
Contributor Author

bric3 commented Dec 2, 2025

@Kyle-Verhoog I'll merge it so progress can be made, but will come back with a test, probably next week.

@bric3 bric3 merged commit 7dde86d into master Dec 2, 2025
18 checks passed
@bric3 bric3 added the enhancement New feature or request label Dec 2, 2025
@bric3 bric3 deleted the bdu/controllable_version branch December 8, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants