Commit 70cc39e
chore(build): consolidate libdatadog symbols in lib_native (#13984)
Both profiling and src/native depend on libdatadog, but slightly
different manner prior to this PR.
- Profiling consumed statically built libdatadog libraries
- src/native Rust crate simply added libdatadog crates as dependencies
This PR makes sure that we build libdatadog dependency as part of
src/native and export profiling ffi symbols there.
Regarding benchmark SLOs:
- Mostly increasing `max_rss_usage`. Looks ok and acceptable to
@taegyunkim. We're changing the way we build and consume libdatadog
dependency.
[PROF-12235](https://datadoghq.atlassian.net/browse/PROF-12235?atlOrigin=eyJpIjoiNzM4ODY4ZTI3MjFjNGMwMjgzMGUwNjhkODhlNjA1NjIiLCJwIjoiaiJ9)
## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
[PROF-12235]:
https://datadoghq.atlassian.net/browse/PROF-12235?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
---------
Signed-off-by: Taegyun Kim <[email protected]>
Co-authored-by: Taegyun Kim <[email protected]>
Co-authored-by: Gabriele N. Tornetta <[email protected]>1 parent 336704e commit 70cc39e
File tree
20 files changed
+2888
-635
lines changed- .github/workflows
- .gitlab/benchmarks
- ddtrace
- appsec/_iast/_taint_tracking
- internal/datadog/profiling
- cmake
- crashtracker
- dd_wrapper
- test
- ddup
- src/native
- .cargo
20 files changed
+2888
-635
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
73 | | - | |
| 73 | + | |
74 | 74 | | |
75 | 75 | | |
76 | 76 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
87 | | - | |
| 87 | + | |
88 | 88 | | |
89 | 89 | | |
90 | 90 | | |
| |||
122 | 122 | | |
123 | 123 | | |
124 | 124 | | |
125 | | - | |
| 125 | + | |
126 | 126 | | |
127 | 127 | | |
128 | 128 | | |
129 | | - | |
| 129 | + | |
130 | 130 | | |
131 | 131 | | |
132 | 132 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
| 38 | + | |
| 39 | + | |
38 | 40 | | |
39 | 41 | | |
40 | 42 | | |
| |||
271 | 273 | | |
272 | 274 | | |
273 | 275 | | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
274 | 279 | | |
275 | 280 | | |
276 | 281 | | |
| |||
316 | 321 | | |
317 | 322 | | |
318 | 323 | | |
319 | | - | |
| 324 | + | |
0 commit comments