Commit e562d52
authored
chore(iast): improve performance (#15609)
## Description
This PR introduces two environment variables to significantly reduce
memory usage in IAST taint tracking operations, particularly for
join_aspect with large strings or many items.
### New Environment Variables
1. DD_IAST_TRUNCATION_MAX_VALUE_LENGTH (default: 250)
Limits the size of Source.value stored in TaintRange objects, preventing
unbounded string storage.
2. DD_IAST_MAX_RANGE_COUNT (default: 10)
Limits the number of TaintRange objects per TaintedObject, preventing
memory growth when joining many items.
### Performance Improvements
Memory Overhead (join_long_items: 1000 iterations, 10 items × 1KB each)
| Metric | Before | After | Improvement |
|-----------------------|-------------------------|--------------------|-----------------|
| Baseline (no IAST) | 20.31 KB | 20.31 KB | - |
| With IAST | N/A (unbounded) | 43.42 KB | Bounded |
| IAST Overhead | Scales with string size | 23.11 KB (+113.8%) | 23
bytes/iter |
| Source.value storage | Up to 10KB+ per range | Max 250 chars | 97.5%
reduction |
| Max ranges per object | 100 | 10 | 90% reduction |
String Size Scaling Test
| String Size | # Items | Ranges (Before) | Ranges (After) | Memory
Scaling |
|-------------|---------|-----------------|----------------|------------------------|
| 5 chars | 500 | ~999 | ≤10 | Independent of size ✅ |
| 500 chars | 500 | ~999 | ≤10 | Independent of size ✅ |
| 5000 chars | 500 | ~999 | ≤10 | Independent of size ✅ |
Allocation Reduction
| Operation | TaintRange Allocations (Before) | TaintRange Allocations
(After) |
|-----------------------------|---------------------------------|--------------------------------|
| Join 5 items | 8 ranges × unlimited | 8 ranges (limited to 10) |
| Join 100 items | 198 ranges × unlimited | 10 ranges (capped) |
| 5000 iterations × 100 items | 990,000 allocations | 50,000 allocations
(-95%) |1 parent ee002af commit e562d52
File tree
20 files changed
+821
-17
lines changed- ddtrace
- appsec
- _iast
- _taint_tracking
- aspects
- taint_tracking
- internal/settings
- tests
- appsec
- iast_memcheck
- iast
- aspects
- taint_sinks
- telemetry
20 files changed
+821
-17
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
132 | 132 | | |
133 | 133 | | |
134 | 134 | | |
| 135 | + | |
135 | 136 | | |
136 | 137 | | |
137 | 138 | | |
| |||
153 | 154 | | |
154 | 155 | | |
155 | 156 | | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
156 | 160 | | |
157 | 161 | | |
158 | 162 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
| 29 | + | |
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| 22 | + | |
22 | 23 | | |
| 24 | + | |
23 | 25 | | |
24 | 26 | | |
25 | 27 | | |
| |||
246 | 248 | | |
247 | 249 | | |
248 | 250 | | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
249 | 263 | | |
250 | 264 | | |
251 | 265 | | |
| |||
Lines changed: 55 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
1 | 3 | | |
2 | 4 | | |
3 | 5 | | |
| |||
6 | 8 | | |
7 | 9 | | |
8 | 10 | | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
9 | 62 | | |
10 | 63 | | |
11 | | - | |
| 64 | + | |
12 | 65 | | |
13 | 66 | | |
14 | 67 | | |
15 | 68 | | |
16 | 69 | | |
17 | 70 | | |
18 | | - | |
| 71 | + | |
19 | 72 | | |
20 | 73 | | |
21 | 74 | | |
| |||
Lines changed: 13 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
33 | 45 | | |
34 | 46 | | |
35 | 47 | | |
| |||
44 | 56 | | |
45 | 57 | | |
46 | 58 | | |
47 | | - | |
| 59 | + | |
48 | 60 | | |
49 | 61 | | |
50 | 62 | | |
| |||
Lines changed: 43 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
3 | 4 | | |
4 | 5 | | |
5 | 6 | | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
6 | 48 | | |
7 | 49 | | |
8 | 50 | | |
| |||
74 | 116 | | |
75 | 117 | | |
76 | 118 | | |
77 | | - | |
| 119 | + | |
78 | 120 | | |
79 | 121 | | |
80 | 122 | | |
| |||
Lines changed: 23 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
5 | 13 | | |
6 | 14 | | |
7 | 15 | | |
| |||
10 | 18 | | |
11 | 19 | | |
12 | 20 | | |
13 | | - | |
14 | 21 | | |
15 | 22 | | |
16 | 23 | | |
| |||
35 | 42 | | |
36 | 43 | | |
37 | 44 | | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
38 | 60 | | |
39 | 61 | | |
40 | 62 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| 23 | + | |
23 | 24 | | |
24 | 25 | | |
25 | 26 | | |
26 | 27 | | |
27 | 28 | | |
28 | 29 | | |
29 | 30 | | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
30 | 44 | | |
31 | 45 | | |
32 | 46 | | |
| |||
258 | 272 | | |
259 | 273 | | |
260 | 274 | | |
261 | | - | |
| 275 | + | |
262 | 276 | | |
263 | 277 | | |
264 | 278 | | |
| |||
342 | 356 | | |
343 | 357 | | |
344 | 358 | | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
345 | 363 | | |
346 | 364 | | |
347 | 365 | | |
| |||
373 | 391 | | |
374 | 392 | | |
375 | 393 | | |
376 | | - | |
| 394 | + | |
377 | 395 | | |
378 | 396 | | |
379 | 397 | | |
380 | 398 | | |
381 | | - | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
382 | 403 | | |
383 | 404 | | |
384 | 405 | | |
385 | 406 | | |
386 | 407 | | |
387 | | - | |
| 408 | + | |
388 | 409 | | |
389 | 410 | | |
390 | 411 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| 14 | + | |
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
| |||
81 | 82 | | |
82 | 83 | | |
83 | 84 | | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
84 | 88 | | |
85 | 89 | | |
86 | 90 | | |
| |||
219 | 223 | | |
220 | 224 | | |
221 | 225 | | |
| 226 | + | |
222 | 227 | | |
223 | 228 | | |
224 | 229 | | |
| |||
0 commit comments