cargo clippy

JohnAZoidberg · JohnAZoidberg · commit fdd553bff647 · 2026-08-05T18:34:09.000+08:00
https://rust-lang.github.io/rust-clippy/rust-1.97.0/index.html#byte_char_slices Also flip from le to be for more readable code Signed-off-by: Daniel Schaefer <dhs@frame.work>
diff --git a/framework_lib/src/ccgx/hid.rs b/framework_lib/src/ccgx/hid.rs
@@ -144,10 +144,10 @@ fn decode_fw_info(buf: &[u8]) -> HidFirmwareInfo {
 
     // TODO: Return Option?
     assert_eq!(info.report_id, ReportIdCmd::E0Read as u8);
-    if info.signature != [b'C', b'Y'] {
+    if info.signature != *b"CY" {
         println!("{:X?}", info);
     }
-    assert_eq!(info.signature, [b'C', b'Y']);
+    assert_eq!(info.signature, *b"CY");
 
     info
 }
@@ -157,7 +157,7 @@ fn print_fw_info(info: &HidFirmwareInfo, verbose: bool) {
 
     info!("  Signature:            {:X?}", info.signature);
     // Something's totally off if the signature is invalid
-    if info.signature != [b'C', b'Y'] {
+    if info.signature != *b"CY" {
         error!("Firmware Signature is invalid.");
         return;
     }
diff --git a/framework_lib/src/ccgx/mod.rs b/framework_lib/src/ccgx/mod.rs
@@ -31,8 +31,8 @@ const FW2_METADATA_ROW_CCG8: u32 = 0x3FF;
 const METADATA_OFFSET: usize = 0xC0; // TODO: Is this 0x40 on ADL?
 const CCG8_METADATA_OFFSET: usize = 0x80;
 const CCG3_METADATA_OFFSET: usize = 0x40;
-const METADATA_MAGIC: u16 = u16::from_le_bytes([b'Y', b'C']); // CY (Cypress)
-const CCG8_METADATA_MAGIC: u16 = u16::from_le_bytes([b'F', b'I']); // IF (Infineon)
+const METADATA_MAGIC: u16 = u16::from_be_bytes(*b"CY"); // CY (Cypress)
+const CCG8_METADATA_MAGIC: u16 = u16::from_be_bytes(*b"IF"); // IF (Infineon)
 
 #[repr(C, packed)]
 #[derive(FromBytes, KnownLayout, Debug, Copy, Clone)]

Original file line number	Diff line number	Diff line change
`@@ -144,10 +144,10 @@ fn decode_fw_info(buf: &[u8]) -> HidFirmwareInfo {`
`144`	`144`
`145`	`145`	`// TODO: Return Option?`
`146`	`146`	`assert_eq!(info.report_id, ReportIdCmd::E0Read as u8);`
`147`		`- if info.signature != [b'C', b'Y'] {`
	`147`	`+ if info.signature != *b"CY" {`
`148`	`148`	`println!("{:X?}", info);`
`149`	`149`	`}`
`150`		`- assert_eq!(info.signature, [b'C', b'Y']);`
	`150`	`+ assert_eq!(info.signature, *b"CY");`
`151`	`151`
`152`	`152`	`info`
`153`	`153`	`}`
`@@ -157,7 +157,7 @@ fn print_fw_info(info: &HidFirmwareInfo, verbose: bool) {`
`157`	`157`
`158`	`158`	`info!(" Signature: {:X?}", info.signature);`
`159`	`159`	`// Something's totally off if the signature is invalid`
`160`		`- if info.signature != [b'C', b'Y'] {`
	`160`	`+ if info.signature != *b"CY" {`
`161`	`161`	`error!("Firmware Signature is invalid.");`
`162`	`162`	`return;`
`163`	`163`	`}`