Skip to content

Fix test_rootMessageShouldOnlyBeVisibleInTheLastPageInThread and ignore flaky test_quotedReplyInThreadAndAlsoInChannel E2E test#6306

Merged
gpunto merged 4 commits intov7from
bug/ignore_flaky_e2e_test
Mar 30, 2026
Merged

Fix test_rootMessageShouldOnlyBeVisibleInTheLastPageInThread and ignore flaky test_quotedReplyInThreadAndAlsoInChannel E2E test#6306
gpunto merged 4 commits intov7from
bug/ignore_flaky_e2e_test

Conversation

@VelikovPetar
Copy link
Copy Markdown
Contributor

@VelikovPetar VelikovPetar commented Mar 27, 2026

Goal

  • Ignore flaky test_quotedReplyInThreadAndAlsoInChannel test until re-design is complete
  • Fix test_rootMessageShouldOnlyBeVisibleInTheLastPageInThread test

Implementation

  • Ignore flaky test_quotedReplyInThreadAndAlsoInChannel test until re-design is complete
  • Fix test_rootMessageShouldOnlyBeVisibleInTheLastPageInThread test

Testing

Builds should not fail for this test

Summary by CodeRabbit

  • Tests
    • Disabled a test case related to quoted replies in threads to address a known issue.
    • Adjusted test parameters to improve reliability of thread message pagination testing.

@VelikovPetar VelikovPetar added the pr:ignore-for-release Exclude from release notes label Mar 27, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 27, 2026

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled.

🎉 Great job! This PR is ready for review.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 27, 2026

SDK Size Comparison 📏

SDK Before After Difference Status
stream-chat-android-client 5.25 MB 5.68 MB 0.43 MB 🟡
stream-chat-android-ui-components 10.60 MB 10.99 MB 0.39 MB 🟡
stream-chat-android-compose 12.81 MB 12.11 MB -0.70 MB 🚀

@sonarqubecloud
Copy link
Copy Markdown

@VelikovPetar VelikovPetar changed the title Ignore flaky test_quotedReplyInThreadAndAlsoInChannel E2E test Fix test_rootMessageShouldOnlyBeVisibleInTheLastPageInThread and ignore flaky test_quotedReplyInThreadAndAlsoInChannel E2E test Mar 30, 2026
@VelikovPetar VelikovPetar marked this pull request as ready for review March 30, 2026 15:59
@VelikovPetar VelikovPetar requested a review from a team as a code owner March 30, 2026 15:59
@gpunto gpunto merged commit e4994a4 into v7 Mar 30, 2026
19 checks passed
@gpunto gpunto deleted the bug/ignore_flaky_e2e_test branch March 30, 2026 16:02
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 30, 2026

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

The PR modifies E2E tests in the quoted reply test suite. One test is disabled via @Ignore annotation referencing a linear issue, and another test's pagination scroll count is increased from 5 to 8 to properly trigger parent-message loading behavior.

Changes

Cohort / File(s) Summary
Test Configuration & Adjustments
stream-chat-android-compose-sample/src/androidTestE2eDebug/kotlin/io/getstream/chat/android/compose/tests/QuotedReplyTests.kt
Added @Ignore annotation to test_quotedReplyInThreadAndAlsoInChannel test. Increased pagination scroll count from 5 to 8 in test_rootMessageShouldOnlyBeVisibleInTheLastPageInThread to adjust control flow for triggering parent-message loading.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

pr:test, pr:ci

Suggested reviewers

  • andremion
  • gpunto

Poem

🐰 A test pauses for investigation,
While scrolling bounds find elevation,
Eight hops instead of five will do,
The parent message waits for you,
Progress made in testing's brew! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes both main changes: fixing one E2E test and ignoring another flaky test, matching the actual changeset.
Description check ✅ Passed The description covers Goal, Implementation, and Testing sections but is missing UI Changes section and ☑️Contributor/Reviewer Checklists specified in the template.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bug/ignore_flaky_e2e_test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:ignore-for-release Exclude from release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants