-
Notifications
You must be signed in to change notification settings - Fork 179
feat: 1 CI jobs to pack chocolatey package, 1 CI job to push it #1093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
360086d to
8886435
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1093 +/- ##
=======================================
Coverage 91.89% 91.89%
=======================================
Files 144 144
Lines 6081 6081
=======================================
Hits 5588 5588
Misses 493 493
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9973df4 to
cbb4678
Compare
1e721bc to
5ff2471
Compare
agateau-gg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor logging remarks but this looks good.
GitHub won't let me comment in the right place in the build-os-package script, but it would also be good to add choco to the $REQUIREMENTS in init_system_vars() (like we add npfm in the Linux branch on line 105).
Approving pre-emptively.
1059d88 to
cca2799
Compare
Context
Added job to push package to Chocolatey wasn't working.
What has been done
push-to-chocolateyscript into 2 scripts:packandpush. Added arguments to those scripts (convenient in CI + when ran manually).packscript to build nupkg package and add it to release assets jobs. Also testing the nupkg in the CI.pushpart to release it to Chocolatey store in the same pipeline as the other releases.Validation
PR check list
skip-changeloglabel has been added to the PR.