Skip to content

Conversation

@sevbch
Copy link
Collaborator

@sevbch sevbch commented May 6, 2025

Context

Added job to push package to Chocolatey wasn't working.

What has been done

  • Split previous push-to-chocolatey script into 2 scripts: pack and push. Added arguments to those scripts (convenient in CI + when ran manually).
  • Use the pack script to build nupkg package and add it to release assets jobs. Also testing the nupkg in the CI.
  • Use the push part to release it to Chocolatey store in the same pipeline as the other releases.

Validation

  • Tested all the scripts manually on a Windows VM.
  • The pack + test job is ran in this MR and ✅
  • About the the push job, we'll be able to confirm it works only on next release.

PR check list

  • As much as possible, the changes include tests (unit and/or functional)
  • If the changes affect the end user (new feature, behavior change, bug fix) then the PR has a changelog entry (see doc/dev/getting-started.md). If the changes do not affect the end user, then the skip-changelog label has been added to the PR.

@sevbch sevbch force-pushed the severine/fix-choco-publication branch from 360086d to 8886435 Compare May 6, 2025 13:42
@codecov
Copy link

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.89%. Comparing base (78bfce1) to head (cca2799).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1093   +/-   ##
=======================================
  Coverage   91.89%   91.89%           
=======================================
  Files         144      144           
  Lines        6081     6081           
=======================================
  Hits         5588     5588           
  Misses        493      493           
Flag Coverage Δ
unittests 91.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sevbch sevbch force-pushed the severine/fix-choco-publication branch 2 times, most recently from 9973df4 to cbb4678 Compare May 6, 2025 14:44
@sevbch sevbch marked this pull request as ready for review May 6, 2025 15:34
@sevbch sevbch requested a review from a team as a code owner May 6, 2025 15:34
@sevbch sevbch self-assigned this May 6, 2025
@sevbch sevbch requested a review from agateau-gg May 6, 2025 15:35
@sevbch sevbch force-pushed the severine/fix-choco-publication branch 4 times, most recently from 1e721bc to 5ff2471 Compare May 7, 2025 15:38
@sevbch sevbch requested a review from agateau-gg May 7, 2025 15:42
Copy link
Collaborator

@agateau-gg agateau-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor logging remarks but this looks good.

GitHub won't let me comment in the right place in the build-os-package script, but it would also be good to add choco to the $REQUIREMENTS in init_system_vars() (like we add npfm in the Linux branch on line 105).

Approving pre-emptively.

@sevbch sevbch force-pushed the severine/fix-choco-publication branch from 1059d88 to cca2799 Compare May 9, 2025 08:54
@sevbch sevbch enabled auto-merge May 9, 2025 08:54
@sevbch sevbch merged commit a157352 into main May 9, 2025
29 checks passed
@sevbch sevbch deleted the severine/fix-choco-publication branch May 9, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants