fix: docker pull fallback on linux amd64 for apple silicon #1104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
A user reported the following issue on Apple Silicon:
After pulling the image separately (using
docker pull bimapangestu/pertamina-login:latestordocker pull --platform linux/amd64 bimapangestu/pertamina-login:latest), it ended working.What has been done
When
docker pullcommand fails, retry pulling specifically thelinux/amd64image.Validation
Use case on Apple Silicon:
bimapangestu/pertamina-login:latestimage (docker rmi -f bimapangestu/pertamina-login:latest)ggshield secret scan docker bimapangestu/pertamina-login:latestonmain: command failsExtra comment
I first added the fallback only for Apple Silicon OS and was advised to make it available for every kind of platform. I'm not opinionated on the topic.
PR check list
skip-changeloglabel has been added to the PR.