Merge pull request #21066 from Homebrew/github_actions_env_helper

Use GitHub Actions helper method more consistently.

Author: MikeMcQuaid

Library/Homebrew/dev-cmd/test-bot.rb

@@ -120,7 +120,7 @@ class TestBotCmd < AbstractCommand
 
       sig { override.void }
       def run
-        if ENV["GITHUB_ACTIONS"].present?
+        if GitHub::Actions.env_set?
           ENV["HOMEBREW_COLOR"] = "1"
           ENV["HOMEBREW_GITHUB_ACTIONS"] = "1"
         end

Library/Homebrew/formula_auditor.rb

@@ -545,7 +545,7 @@ def audit_homepage
 
       # Skip gnu.org and nongnu.org audit on GitHub runners
       # See issue: https://github.com/Homebrew/homebrew-core/issues/206757
-      github_runner = ENV.fetch("GITHUB_ACTIONS", nil) && !ENV["GITHUB_ACTIONS_HOMEBREW_SELF_HOSTED"]
+      github_runner = GitHub::Actions.env_set? && !ENV["GITHUB_ACTIONS_HOMEBREW_SELF_HOSTED"]
       return if homepage.match?(%r{^https?://www\.(?:non)?gnu\.org/.+}) && github_runner
 
       use_homebrew_curl = [:stable, :head].any? do |spec_name|

Library/Homebrew/test_bot.rb

@@ -24,11 +24,11 @@ module TestBot
     HOMEBREW_TAP_REGEX = %r{^([\w-]+)/homebrew-([\w-]+)$}
 
     def cleanup?(args)
-      args.cleanup? || ENV["GITHUB_ACTIONS"].present?
+      args.cleanup? || GitHub::Actions.env_set?
     end
 
     def local?(args)
-      args.local? || ENV["GITHUB_ACTIONS"].present?
+      args.local? || GitHub::Actions.env_set?
     end
 
     def resolve_test_tap(tap = nil)

Library/Homebrew/test_bot/formulae.rb

@@ -68,7 +68,7 @@ def run!(args:)
           puts
         end
 
-        return unless ENV["GITHUB_ACTIONS"]
+        return unless GitHub::Actions.env_set?
 
         # Remove `bash` after it is tested, since leaving a broken `bash`
         # installation in the environment can cause issues with subsequent
@@ -355,7 +355,7 @@ def livecheck(formula)
             "Error encountered (no message provided)"
           end
 
-          if ENV["GITHUB_ACTIONS"].present?
+          if GitHub::Actions.env_set?
             puts GitHub::Actions::Annotation.new(
               :error,
               error_msg,
@@ -383,7 +383,7 @@ def livecheck(formula)
           "The formula version is newer than the version from `brew livecheck`."
         end
 
-        if ENV["GITHUB_ACTIONS"].present?
+        if GitHub::Actions.env_set?
           puts GitHub::Actions::Annotation.new(
             :warning,
             newer_than_upstream_msg,
@@ -433,7 +433,7 @@ def formula!(formula_name, args:)
         build_flag = if build_bottle?(formula, args:)
           "--build-bottle"
         else
-          if ENV["GITHUB_ACTIONS"].present?
+          if GitHub::Actions.env_set?
             puts GitHub::Actions::Annotation.new(
               :warning,
               "#{formula} has unbottled dependencies, so a bottle will not be built.",

Library/Homebrew/test_bot/formulae_dependents.rb

@@ -44,7 +44,7 @@ def run!(args:)
           puts
         end
 
-        return unless ENV["GITHUB_ACTIONS"]
+        return unless GitHub::Actions.env_set?
 
         # Remove `bash` after it is tested, since leaving a broken `bash`
         # installation in the environment can cause issues with subsequent
@@ -360,7 +360,7 @@ def install_dependent(dependent, testable_dependents, args:, build_from_source:
           @tested_dependents_list.write("\n", mode: "a")
         end
 
-        return if ENV["GITHUB_ACTIONS"].blank?
+        return unless GitHub::Actions.env_set?
 
         if build_from_source &&
            !bottled_on_current_version &&

Library/Homebrew/test_bot/formulae_detect.rb

@@ -18,7 +18,7 @@ def initialize(argument, tap:, git:, dry_run:, fail_fast:, verbose:)
       def run!(args:)
         detect_formulae!(args:)
 
-        return unless ENV["GITHUB_ACTIONS"]
+        return unless GitHub::Actions.env_set?
 
         File.open(ENV.fetch("GITHUB_OUTPUT"), "a") do |f|
           f.puts "testing_formulae=#{@testing_formulae.join(",")}"
@@ -60,7 +60,7 @@ def detect_formulae!(args:)
 
         github_sha = ENV.fetch("GITHUB_SHA", nil)
         if github_repository.blank? || github_sha.blank? || github_ref.blank?
-          if ENV["GITHUB_ACTIONS"]
+          if GitHub::Actions.env_set?
             odie <<~EOS
               We cannot find the needed GitHub Actions environment variables! Check you have e.g. exported them to a Docker container.
             EOS

Library/Homebrew/test_bot/step.rb

@@ -2,6 +2,7 @@
 # frozen_string_literal: true
 
 require "system_command"
+require "utils/github/actions"
 
 module Homebrew
   module TestBot
@@ -75,12 +76,8 @@ def puts_result
         puts Formatter.headline(Formatter.error("FAILED"), color: :red) unless passed?
       end
 
-      def in_github_actions?
-        ENV["GITHUB_ACTIONS"].present?
-      end
-
       def puts_github_actions_annotation(message, title, file, line)
-        return unless in_github_actions?
+        return unless GitHub::Actions.env_set?
 
         type = if passed?
           :notice
@@ -95,9 +92,9 @@ def puts_github_actions_annotation(message, title, file, line)
       end
 
       def puts_in_github_actions_group(title)
-        puts "::group::#{title}" if in_github_actions?
+        puts "::group::#{title}" if GitHub::Actions.env_set?
         yield
-        puts "::endgroup::" if in_github_actions?
+        puts "::endgroup::" if GitHub::Actions.env_set?
       end
 
       def output?
@@ -211,7 +208,7 @@ def run(dry_run: false, fail_fast: false)
 
         puts_full_output
 
-        unless in_github_actions?
+        unless GitHub::Actions.env_set?
           puts
           exit 1 if fail_fast && failed?
           return

Library/Homebrew/test_bot/test_formulae.rb

@@ -34,7 +34,7 @@ def github_event_payload
       def previous_github_sha
         return if tap.blank?
         return unless repository.directory?
-        return if ENV["GITHUB_ACTIONS"].blank?
+        return unless GitHub::Actions.env_set?
         return if (payload = github_event_payload).blank?
 
         head_repo_owner = payload.dig("pull_request", "head", "repo", "owner", "login")
@@ -255,7 +255,7 @@ def install_formula_from_bottle!(formula_name, testing_formulae_dependents:, dry
           end
           bottle_message = "Bottle for #{formula_name} built at #{bottle_commit_details}".strip
 
-          if ENV["GITHUB_ACTIONS"].present?
+          if GitHub::Actions.env_set?
             puts GitHub::Actions::Annotation.new(
               :notice,
               bottle_message,