Cleanup partial download queue installations on error/interrupt

This will port the similar logic from `formula_installer.rb` that
handles errors or manual user interrupts from producing partial
installations.

I noticed this code is almost identical (with some missing edge-cases)
in `formula_installer.rb` to `Keg#uninstall` so I added a new
`Keg#uninstall_ignore_interrupts_and_raise_failures!` method and made
both `formula_installer.rb` and `retryable_download.rb` use it.

Author: MikeMcQuaid

Library/Homebrew/formula_installer.rb

@@ -593,17 +593,7 @@ def install
         pour
       # Catch any other types of exceptions as they leave us with nothing installed.
       rescue Exception # rubocop:disable Lint/RescueException
-        ignore_interrupts do
-          begin
-            FileUtils.rm_r(formula.prefix) if formula.prefix.directory?
-          rescue Errno::EACCES, Errno::ENOTEMPTY
-            odie <<~EOS
-              Could not remove #{formula.prefix.basename} keg! Do so manually:
-                sudo rm -rf #{formula.prefix}
-            EOS
-          end
-          formula.rack.rmdir_if_possible
-        end
+        Keg.new(formula.prefix).uninstall_ignore_interrupts_and_raise_failures! if formula.prefix.directory?
         raise
       else
         @poured_bottle = true

Library/Homebrew/keg.rb

@@ -279,6 +279,7 @@ def remove_opt_record
     opt_record.parent.rmdir_if_possible
   end
 
+  sig { params(raise_failures: T::Boolean).void }
   def uninstall(raise_failures: false)
     CacheStoreDatabase.use(:linkage) do |db|
       break unless db.created?
@@ -301,6 +302,13 @@ def uninstall(raise_failures: false)
     EOS
   end
 
+  sig { void }
+  def uninstall_ignore_interrupts_and_raise_failures!
+    ignore_interrupts do
+      uninstall(raise_failures: true)
+    end
+  end
+
   def unlink(verbose: false, dry_run: false)
     ObserverPathnameExtension.reset_counts!
 

Library/Homebrew/retryable_download.rb

@@ -80,6 +80,10 @@ def fetch(verify_download_integrity: true, timeout: nil, quiet: false)
 
       if pour && downloadable.is_a?(Bottle)
         HOMEBREW_CELLAR.mkpath
+
+        bottle_filename = T.cast(downloadable, Bottle).filename
+        bottle_keg = HOMEBREW_CELLAR/bottle_filename.name/bottle_filename.version.to_s
+
         UnpackStrategy.detect(download, prioritize_extension: true)
                       .extract_nestedly(to: HOMEBREW_CELLAR)
       elsif json_download
@@ -89,7 +93,10 @@ def fetch(verify_download_integrity: true, timeout: nil, quiet: false)
       download
     rescue DownloadError, ChecksumMismatchError, Resource::BottleManifest::Error
       tries_remaining = @tries - @try
-      raise if tries_remaining.zero?
+      if tries_remaining.zero?
+        cleanup_partial_installation_on_error!(bottle_keg)
+        raise
+      end
 
       wait = 2 ** @try
       unless quiet
@@ -100,6 +107,10 @@ def fetch(verify_download_integrity: true, timeout: nil, quiet: false)
 
       downloadable.clear_cache
       retry
+    # Catch any other types of exceptions as they leave us with partial installations.
+    rescue Exception # rubocop:disable Lint/RescueException
+      cleanup_partial_installation_on_error!(bottle_keg)
+      raise
     end
 
     sig { override.params(filename: Pathname).void }
@@ -112,5 +123,13 @@ def verify_download_integrity(filename) = downloadable.verify_download_integrity
 
     sig { returns(T::Boolean) }
     attr_reader :pour
+
+    sig { params(path: T.nilable(Pathname)).void }
+    def cleanup_partial_installation_on_error!(path)
+      return if path.nil?
+      return unless path.directory?
+
+      Keg.new(path).uninstall_ignore_interrupts_and_raise_failures!
+    end
   end
 end