Add typing to satisfy Sorbet

Signed-off-by: Patrick Linnane <[email protected]>

Author: p-linnane

Library/Homebrew/sorbet/tapioca/compilers/cask/config.rb

@@ -7,9 +7,9 @@
 module Tapioca
   module Compilers
     class CaskConfig < Tapioca::Dsl::Compiler
-      ConstantType = type_member { { fixed: Module } }
+      ConstantType = type_member { { fixed: T::Module[T.anything] } }
 
-      sig { override.returns(T::Enumerable[Module]) }
+      sig { override.returns(T::Enumerable[T::Module[T.anything]]) }
       def self.gather_constants = [Cask::Config]
 
       sig { override.void }

Library/Homebrew/sorbet/tapioca/compilers/env_config.rb

@@ -7,9 +7,9 @@
 module Tapioca
   module Compilers
     class EnvConfig < Tapioca::Dsl::Compiler
-      ConstantType = type_member { { fixed: Module } }
+      ConstantType = type_member { { fixed: T::Module[T.anything] } }
 
-      sig { override.returns(T::Enumerable[Module]) }
+      sig { override.returns(T::Enumerable[T::Module[T.anything]]) }
       def self.gather_constants = [Homebrew::EnvConfig]
 
       sig { override.void }

Library/Homebrew/sorbet/tapioca/compilers/forwardables.rb

@@ -20,9 +20,9 @@ class Forwardables < Tapioca::Dsl::Compiler
         },
       }.freeze, T::Hash[String, T::Hash[String, String]])
 
-      ConstantType = type_member { { fixed: Module } }
+      ConstantType = type_member { { fixed: T::Module[T.anything] } }
 
-      sig { override.returns(T::Enumerable[Module]) }
+      sig { override.returns(T::Enumerable[T::Module[T.anything]]) }
       def self.gather_constants
         Homebrew::Tapioca::Utils.named_objects_with_module(Forwardable).reject do |obj|
           # Avoid duplicate stubs for forwardables that are defined in vendored gems

Library/Homebrew/sorbet/tapioca/compilers/rubocop.rb

@@ -10,8 +10,8 @@ module Compilers
     class RuboCop < Tapioca::Dsl::Compiler
       # This should be a module whose singleton class contains RuboCop::AST::NodePattern::Macros,
       #   but I don't know how to express that in Sorbet.
-      ConstantType = type_member { { fixed: Module } }
-      sig { override.returns(T::Enumerable[Module]) }
+      ConstantType = type_member { { fixed: T::Module[T.anything] } }
+      sig { override.returns(T::Enumerable[T::Module[T.anything]]) }
       def self.gather_constants
         all_modules.select do |klass|
           next unless klass.singleton_class < ::RuboCop::AST::NodePattern::Macros

Library/Homebrew/sorbet/tapioca/compilers/rubocop_cask_ast_stanza.rb

@@ -8,9 +8,9 @@
 module Tapioca
   module Compilers
     class Stanza < Tapioca::Dsl::Compiler
-      ConstantType = type_member { { fixed: Module } }
+      ConstantType = type_member { { fixed: T::Module[T.anything] } }
 
-      sig { override.returns(T::Enumerable[Module]) }
+      sig { override.returns(T::Enumerable[T::Module[T.anything]]) }
       def self.gather_constants = [::RuboCop::Cask::AST::Stanza]
 
       sig { override.void }

Library/Homebrew/sorbet/tapioca/compilers/tty.rb

@@ -7,9 +7,9 @@
 module Tapioca
   module Compilers
     class Tty < Tapioca::Dsl::Compiler
-      ConstantType = type_member { { fixed: Module } }
+      ConstantType = type_member { { fixed: T::Module[T.anything] } }
 
-      sig { override.returns(T::Enumerable[Module]) }
+      sig { override.returns(T::Enumerable[T::Module[T.anything]]) }
       def self.gather_constants = [::Tty]
 
       sig { override.void }

Library/Homebrew/sorbet/tapioca/utils.rb

@@ -4,7 +4,7 @@
 module Homebrew
   module Tapioca
     module Utils
-      sig { params(klass: T::Class[T.anything]).returns(Module) }
+      sig { params(klass: T::Class[T.anything]).returns(T::Module[T.anything]) }
       def self.named_object_for(klass)
         return klass if klass.name
 
@@ -18,7 +18,7 @@ def self.named_object_for(klass)
       # @param class_methods [Boolean] whether to get class methods or instance methods
       # @return the `module` methods that are defined in the given file
       sig {
-        params(mod: Module, file_name: String,
+        params(mod: T::Module[T.anything], file_name: String,
                class_methods: T::Boolean).returns(T::Array[T.any(Method, UnboundMethod)])
       }
       def self.methods_from_file(mod, file_name, class_methods: false)
@@ -30,7 +30,7 @@ def self.methods_from_file(mod, file_name, class_methods: false)
         methods.select { _1.source_location&.first&.end_with?(file_name) }
       end
 
-      sig { params(mod: Module).returns(T::Array[Module]) }
+      sig { params(mod: T::Module[T.anything]).returns(T::Array[T::Module[T.anything]]) }
       def self.named_objects_with_module(mod)
         ObjectSpace.each_object(mod).map do |obj|
           case obj

Library/Homebrew/utils.rb

@@ -76,9 +76,9 @@ def self.system(cmd, argv0 = nil, *args, **options)
 
   # `Module` and `Regexp` are global variables used as types here so they don't need to be imported
   # rubocop:disable Style/GlobalVars
-  sig { params(the_module: Module, pattern: Regexp).void }
+  sig { params(the_module: T::Module[T.anything], pattern: Regexp).void }
   def self.inject_dump_stats!(the_module, pattern)
-    @injected_dump_stat_modules ||= T.let({}, T.nilable(T::Hash[Module, T::Array[String]]))
+    @injected_dump_stat_modules ||= T.let({}, T.nilable(T::Hash[T::Module[T.anything], T::Array[String]]))
     @injected_dump_stat_modules[the_module] ||= []
     injected_methods = @injected_dump_stat_modules.fetch(the_module)
     the_module.module_eval do