Skip to content

Add extension for ArrayInterface#19

Merged
goerz merged 1 commit intomasterfrom
array-interface-support
Feb 24, 2026
Merged

Add extension for ArrayInterface#19
goerz merged 1 commit intomasterfrom
array-interface-support

Conversation

@goerz
Copy link
Member

@goerz goerz commented Feb 24, 2026

No description provided.

@goerz goerz added the enhancement New feature or request label Feb 24, 2026
@goerz goerz requested a review from Copilot February 24, 2026 22:47
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds an ArrayInterface extension to enable better integration with packages that use ArrayInterface for array trait queries, specifically to support the check_state validation function from QuantumPropagators.

Changes:

  • Added a new package extension for ArrayInterface in ext/QuantumGradientGeneratorsArrayInterfaceExt.jl
  • Configured ArrayInterface as a weak dependency in Project.toml with version compatibility specification

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
ext/QuantumGradientGeneratorsArrayInterfaceExt.jl Implements ArrayInterface trait methods (ismutable, fast_scalar_indexing) for GradVector types
Project.toml Adds ArrayInterface as weakdep with extension configuration and v7.0 compatibility

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.8%. Comparing base (93391c3) to head (40ce5d0).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
ext/QuantumGradientGeneratorsArrayInterfaceExt.jl 0.0% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master     #19     +/-   ##
========================================
- Coverage    87.5%   86.8%   -0.6%     
========================================
  Files           5       6      +1     
  Lines         278     280      +2     
========================================
  Hits          243     243             
- Misses         35      37      +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@goerz goerz merged commit 0ff751d into master Feb 24, 2026
9 checks passed
@goerz goerz deleted the array-interface-support branch February 24, 2026 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants