Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds an ArrayInterface extension to enable better integration with packages that use ArrayInterface for array trait queries, specifically to support the check_state validation function from QuantumPropagators.
Changes:
- Added a new package extension for ArrayInterface in
ext/QuantumGradientGeneratorsArrayInterfaceExt.jl - Configured ArrayInterface as a weak dependency in
Project.tomlwith version compatibility specification
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ext/QuantumGradientGeneratorsArrayInterfaceExt.jl | Implements ArrayInterface trait methods (ismutable, fast_scalar_indexing) for GradVector types |
| Project.toml | Adds ArrayInterface as weakdep with extension configuration and v7.0 compatibility |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19 +/- ##
========================================
- Coverage 87.5% 86.8% -0.6%
========================================
Files 5 6 +1
Lines 278 280 +2
========================================
Hits 243 243
- Misses 35 37 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.