feat: Standardize SquadAuto#5523
Conversation
dc89f7c to
c1f4fad
Compare
|
This is an initial version of a (potentially standardized) SquadAuto, without TimelineAuto. Once all wikis are on this version, there are also further simplifications possible (e.g. merging SquadAutoPerson and SquadPerson types) |
hjpalpha
left a comment
There was a problem hiding this comment.
spaces --> tabs pls ;)
hjpalpha
left a comment
There was a problem hiding this comment.
probably oos, but long term we probably should use the model for the transfer queries
overall, seems reasonable on phone
ElectricalBoy
left a comment
There was a problem hiding this comment.
some strings use " and others use '; we should use ' to stay consistent with the rest of Lua files
|
Marking this as ready for review. Idea is still to roll out wiki-by-wiki and fix (or implement) necessary things. |
|
Test page with comparison new (left) vs old squadauto: |
Co-authored-by: ElectricalBoy <15651807+ElectricalBoy@users.noreply.github.com>
hjpalpha
left a comment
There was a problem hiding this comment.
on mobile, so could be easily wrong, but does this kick the Squad/rank stuff?
if yes we can expect the wikis that use it to cry if this goes live
It's not supposed to kick it, just not implemented yet. |
Co-authored-by: ElectricalBoy <15651807+ElectricalBoy@users.noreply.github.com>
Summary
Replace old, unmaintainable SquadAuto with a version that is hopefully a bit easier to maintain.
How did you test this change?
dev