[pull] master from JuliaLang:master #2155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt in code (#60324) See PR title. I believe it's a good idea to document this property in code with an assertion, since it's a tricky invariant that makes it safe to use our current lock-free list implementation. In the long term, it might be better to use a lock-free list with an actual ABA-prevention mechanism to make the code more robust.
I had assumed a valid parse since parse errors would detonate in lowering anyway, but that was wrong: JETLS uses `ignore_errors=true` in parsing to SyntaxTree. I plan to make some larger changes where I'll make sure `RawGreenNode->SyntaxTree` is more thoroughly tested, but this is a quick fix to get JETLS working.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )