Skip to content

Commit abef7ac

Browse files
committed
Merge branch 'metrics-renaming' into 'main'
rename some metrics for better readability See merge request lightspeedrtx/dxvk-remix-nv!1586
2 parents 96d7868 + 61c303d commit abef7ac

File tree

2 files changed

+18
-18
lines changed

2 files changed

+18
-18
lines changed

src/dxvk/rtx_render/rtx_context.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -759,8 +759,8 @@ namespace dxvk {
759759

760760
void RtxContext::updateMetrics(const float gpuIdleTimeMilliseconds) const {
761761
ScopedCpuProfileZone();
762-
Metrics::logRollingAverage(Metric::average_frame_time, GlobalTime::get().deltaTimeMs()); // In milliseconds
763-
Metrics::logRollingAverage(Metric::gpu_idle_ticks, gpuIdleTimeMilliseconds); // In milliseconds
762+
Metrics::logRollingAverage(Metric::dxvk_average_frame_time_ms, GlobalTime::get().deltaTimeMs()); // In milliseconds
763+
Metrics::logRollingAverage(Metric::dxvk_gpu_idle_time_ms, gpuIdleTimeMilliseconds); // In milliseconds
764764
uint64_t vidUsageMib = 0;
765765
uint64_t sysUsageMib = 0;
766766
const VkPhysicalDeviceMemoryProperties memprops = m_device->adapter()->memoryProperties();
@@ -775,10 +775,10 @@ namespace dxvk {
775775
sysUsageMib += m_device->getMemoryStats(i).totalUsed() >> 20;
776776
}
777777
}
778-
Metrics::logRollingAverage(Metric::vid_memory_usage, static_cast<float>(vidUsageMib)); // In MB
779-
Metrics::logRollingAverage(Metric::sys_memory_usage, static_cast<float>(sysUsageMib)); // In MB
780-
Metrics::logFloat(Metric::total_time, static_cast<float>(GlobalTime::get().realTimeSinceStartMs()));
781-
Metrics::logFloat(Metric::frame_count, static_cast<float>(m_device->getCurrentFrameId()));
778+
Metrics::logRollingAverage(Metric::dxvk_vid_memory_usage_mb, static_cast<float>(vidUsageMib)); // In MB
779+
Metrics::logRollingAverage(Metric::dxvk_sys_memory_usage_mb, static_cast<float>(sysUsageMib)); // In MB
780+
Metrics::logFloat(Metric::dxvk_total_time_ms, static_cast<float>(GlobalTime::get().realTimeSinceStartMs()));
781+
Metrics::logFloat(Metric::dxvk_frame_count, static_cast<float>(m_device->getCurrentFrameId()));
782782
}
783783

784784
void RtxContext::setConstantBuffers(const uint32_t vsFixedFunctionConstants, const uint32_t psSharedStateConstants, Rc<DxvkBuffer> vertexCaptureCB) {

src/util/log/metrics.h

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,12 @@
3232

3333
namespace dxvk {
3434
enum Metric {
35-
average_frame_time = 0, // In milliseconds
36-
vid_memory_usage, // In MB
37-
sys_memory_usage, // In MB
38-
gpu_idle_ticks, // In milliseconds
39-
total_time, // In milliseconds
40-
frame_count, // Count of rendered frames
35+
dxvk_average_frame_time_ms = 0, // In milliseconds
36+
dxvk_vid_memory_usage_mb, // In MB
37+
dxvk_sys_memory_usage_mb, // In MB
38+
dxvk_gpu_idle_time_ms, // In milliseconds
39+
dxvk_total_time_ms, // In milliseconds
40+
dxvk_frame_count, // Count of rendered frames
4141

4242
kCount
4343
};
@@ -61,12 +61,12 @@ namespace dxvk {
6161

6262
private:
6363
inline static const std::string m_metricNames[] = {
64-
"average_frame_time",
65-
"vid_memory_usage",
66-
"sys_memory_usage",
67-
"gpu_idle_ticks",
68-
"total_time",
69-
"frame_count",
64+
"dxvk_average_frame_time_ms",
65+
"dxvk_vid_memory_usage_mb",
66+
"dxvk_sys_memory_usage_mb",
67+
"dxvk_gpu_idle_time_ms",
68+
"dxvk_total_time_ms",
69+
"dxvk_frame_count",
7070
};
7171

7272
static_assert(std::size(m_metricNames) == kCount, "m_metricNames must have an entry for every Metric enum value");

0 commit comments

Comments
 (0)