SerialImp.c:RXTXCommDriver(testRead) - ignore tcgetattr() failures for hidraw device #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dilyanpalauzov
pushed a commit
to dilyanpalauzov/nrjavaserial
that referenced
this pull request
Nov 5, 2025
…r hidraw device NeuronRobotics#263 If tcgetattr(fd, &ttyset) fails and errno is EINVAL 22 Invalid Argument, or ENOTTY - https://en.wikipedia.org/wiki/Not_a_typewriter, then this is not a serial device and do not try to adjust its settings. First obtain the flags, so that these can be restored later. Why EINVAL and not only ENOTTY? - It should be ENOTTY but is EINVAL : https://lore.kernel.org/linux-input/[email protected]/.
dilyanpalauzov
pushed a commit
to dilyanpalauzov/nrjavaserial
that referenced
this pull request
Nov 7, 2025
…r hidraw device NeuronRobotics#263 If tcgetattr(fd, &ttyset) fails and errno is EINVAL 22 Invalid Argument, or ENOTTY - https://en.wikipedia.org/wiki/Not_a_typewriter, then this is not a serial device and do not try to adjust its settings. First obtain the flags, so that these can be restored later. Why EINVAL and not only ENOTTY? - It should be ENOTTY but is EINVAL : https://lore.kernel.org/linux-input/[email protected]/.
…r hidraw device If tcgetattr(fd, &ttyset) fails and errno is EINVAL 22 Invalid Argument, or ENOTTY - https://en.wikipedia.org/wiki/Not_a_typewriter, then this is not a serial device and do not try to adjust its settings. First obtain the flags, so that these can be restored later.
dilyanpalauzov
force-pushed
the
testread_ignore_tcgetattr_errors
branch
from
670fbcd to
aff84a2
Compare
dilyanpalauzov
pushed a commit
to dilyanpalauzov/nrjavaserial
that referenced
this pull request
Nov 12, 2025
…r hidraw device NeuronRobotics#263 If tcgetattr(fd, &ttyset) fails and errno is EINVAL 22 Invalid Argument, or ENOTTY - https://en.wikipedia.org/wiki/Not_a_typewriter, then this is not a serial device and do not try to adjust its settings. First obtain the flags, so that these can be restored later. Why EINVAL and not only ENOTTY? - It should be ENOTTY but is EINVAL : https://lore.kernel.org/linux-input/[email protected]/.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
tcgetattr(fd, &ttyset)fails and errno is EINVAL 22 Invalid Argument, or ENOTTY - https://en.wikipedia.org/wiki/Not_a_typewriter, then this is not a serial device and do not try to adjust its settings.First obtain the flags, so that these can be restored later.
Why EINVAL and not only ENOTTY? - It should be ENOTTY but is EINVAL : https://lore.kernel.org/linux-input/[email protected]/.