|
| 1 | +# Copyright (C) 2025 Cetmix OÜ |
| 2 | +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). |
| 3 | + |
| 4 | +from unittest.mock import MagicMock, patch |
| 5 | + |
| 6 | +from odoo.tests import common, tagged |
| 7 | + |
| 8 | +from odoo.addons.website_user_login_redirect_custom.controllers.main import ( |
| 9 | + WebsiteRedirectCustom, |
| 10 | +) |
| 11 | + |
| 12 | + |
| 13 | +@tagged("post_install", "-at_install") |
| 14 | +class TestWebsiteLoginRedirectController(common.TransactionCase): |
| 15 | + """Unit tests for WebsiteRedirectCustom controller""" |
| 16 | + |
| 17 | + @classmethod |
| 18 | + def setUpClass(cls): |
| 19 | + super().setUpClass() |
| 20 | + cls.controller = WebsiteRedirectCustom() |
| 21 | + cls.config_parameter = cls.env["ir.config_parameter"].sudo() |
| 22 | + |
| 23 | + cls.portal_user = cls.env["res.users"].create( |
| 24 | + { |
| 25 | + "name": "Portal User", |
| 26 | + |
| 27 | + "groups_id": [(4, cls.env.ref("base.group_portal").id)], |
| 28 | + } |
| 29 | + ) |
| 30 | + |
| 31 | + def _fake_request(self, user, enabled=True, url="/shop"): |
| 32 | + """Create mock request for controller tests""" |
| 33 | + mock_req = MagicMock() |
| 34 | + mock_req.session.uid = user.id |
| 35 | + |
| 36 | + mock_user = MagicMock() |
| 37 | + mock_user.id = user.id |
| 38 | + if user.login.startswith("internal"): |
| 39 | + mock_user.has_group.side_effect = lambda g: g == "base.group_user" |
| 40 | + else: |
| 41 | + mock_user.has_group.side_effect = lambda g: g == "base.group_portal" |
| 42 | + |
| 43 | + mock_env = MagicMock() |
| 44 | + mock_env.user = mock_user |
| 45 | + |
| 46 | + def getitem(name): |
| 47 | + if name == "ir.config_parameter": |
| 48 | + ir_mock = MagicMock() |
| 49 | + ir_mock.sudo.return_value = ir_mock |
| 50 | + ir_mock.get_param.side_effect = lambda key, default=None: { |
| 51 | + "website_user_login_redirect_custom.enabled": "True" |
| 52 | + if enabled |
| 53 | + else "False", |
| 54 | + "website_user_login_redirect_custom.url": url, |
| 55 | + }.get(key, default) |
| 56 | + return ir_mock |
| 57 | + if name == "res.config.settings": |
| 58 | + settings_mock = MagicMock() |
| 59 | + settings_mock.is_valid_redirect_url.side_effect = ( |
| 60 | + lambda value: value |
| 61 | + and value.startswith("/") |
| 62 | + and not value.startswith("//") |
| 63 | + ) |
| 64 | + return settings_mock |
| 65 | + raise KeyError(name) |
| 66 | + |
| 67 | + mock_env.__getitem__.side_effect = getitem |
| 68 | + mock_req.env = mock_env |
| 69 | + return mock_req |
| 70 | + |
| 71 | + def test_should_redirect_custom_portal_user_enabled(self): |
| 72 | + """Portal user with feature enabled should redirect""" |
| 73 | + mock_request = self._fake_request(self.portal_user, enabled=True) |
| 74 | + with patch( |
| 75 | + "odoo.addons.website_user_login_redirect_custom.controllers.main.request", |
| 76 | + mock_request, |
| 77 | + ): |
| 78 | + self.assertTrue(self.controller._should_redirect_custom()) |
| 79 | + |
| 80 | + def test_should_redirect_custom_internal_user(self): |
| 81 | + """Internal users should not redirect""" |
| 82 | + internal_user = self.env["res.users"].create( |
| 83 | + { |
| 84 | + "name": "Internal User", |
| 85 | + |
| 86 | + "groups_id": [(4, self.env.ref("base.group_user").id)], |
| 87 | + } |
| 88 | + ) |
| 89 | + mock_request = self._fake_request(internal_user, enabled=True) |
| 90 | + |
| 91 | + with patch( |
| 92 | + "odoo.addons.website_user_login_redirect_custom.controllers.main.request", |
| 93 | + mock_request, |
| 94 | + ): |
| 95 | + result = self.controller._should_redirect_custom() |
| 96 | + self.assertFalse(result) |
| 97 | + |
| 98 | + def test_get_custom_redirect_url(self): |
| 99 | + """Test custom URL validation and retrieval""" |
| 100 | + # Valid URL |
| 101 | + mock_request = self._fake_request(self.portal_user, url="/shop") |
| 102 | + with patch( |
| 103 | + "odoo.addons.website_user_login_redirect_custom.controllers.main.request", |
| 104 | + mock_request, |
| 105 | + ): |
| 106 | + self.assertEqual(self.controller._get_custom_redirect_url(), "/shop") |
| 107 | + |
| 108 | + # Invalid URL |
| 109 | + mock_request = self._fake_request(self.portal_user, url="http://evil.com") |
| 110 | + with patch( |
| 111 | + "odoo.addons.website_user_login_redirect_custom.controllers.main.request", |
| 112 | + mock_request, |
| 113 | + ): |
| 114 | + self.assertFalse(self.controller._get_custom_redirect_url()) |
| 115 | + |
| 116 | + def test_should_redirect_custom_disabled(self): |
| 117 | + """Feature disabled → no redirect should occur""" |
| 118 | + mock_request = self._fake_request(self.portal_user, enabled=False) |
| 119 | + with patch( |
| 120 | + "odoo.addons.website_user_login_redirect_custom.controllers.main.request", |
| 121 | + mock_request, |
| 122 | + ): |
| 123 | + self.assertFalse(self.controller._should_redirect_custom()) |
| 124 | + |
| 125 | + def test_login_redirect_behavior(self): |
| 126 | + """Verify custom redirect applies when feature enabled""" |
| 127 | + mock_request = self._fake_request( |
| 128 | + self.portal_user, enabled=True, url="/thank-you" |
| 129 | + ) |
| 130 | + with ( |
| 131 | + patch( |
| 132 | + "odoo.addons.website_user_login_redirect_custom.controllers.main.request", |
| 133 | + mock_request, |
| 134 | + ), |
| 135 | + patch( |
| 136 | + "odoo.addons.web.controllers.home.Home._login_redirect", |
| 137 | + return_value="/my", |
| 138 | + ), |
| 139 | + ): |
| 140 | + result = self.controller._login_redirect(self.portal_user.id) |
| 141 | + self.assertEqual(result, "/thank-you") |
| 142 | + |
| 143 | + def test_should_redirect_custom_no_session(self): |
| 144 | + """Should not redirect if user session missing""" |
| 145 | + mock_request = MagicMock() |
| 146 | + mock_request.session.uid = None |
| 147 | + mock_request.env.user.has_group.return_value = False |
| 148 | + with patch( |
| 149 | + "odoo.addons.website_user_login_redirect_custom.controllers.main.request", |
| 150 | + mock_request, |
| 151 | + ): |
| 152 | + self.assertFalse(self.controller._should_redirect_custom()) |
| 153 | + |
| 154 | + def test_get_custom_redirect_url_empty(self): |
| 155 | + """Should return False if URL param is empty""" |
| 156 | + mock_request = MagicMock() |
| 157 | + mock_request.env[ |
| 158 | + "ir.config_parameter" |
| 159 | + ].sudo.return_value.get_param.return_value = "" |
| 160 | + mock_request.env[ |
| 161 | + "res.config.settings" |
| 162 | + ].is_valid_redirect_url.return_value = True |
| 163 | + with patch( |
| 164 | + "odoo.addons.website_user_login_redirect_custom.controllers.main.request", |
| 165 | + mock_request, |
| 166 | + ): |
| 167 | + self.assertFalse(self.controller._get_custom_redirect_url()) |
| 168 | + |
| 169 | + def test_login_redirect_returns_parent_redirect_when_disabled(self): |
| 170 | + """Return parent redirect when feature disabled""" |
| 171 | + mock_request = self._fake_request(self.portal_user, enabled=False, url="/shop") |
| 172 | + with ( |
| 173 | + patch( |
| 174 | + "odoo.addons.website_user_login_redirect_custom.controllers.main.request", |
| 175 | + mock_request, |
| 176 | + ), |
| 177 | + patch( |
| 178 | + "odoo.addons.web.controllers.home.Home._login_redirect", |
| 179 | + return_value="/custom", |
| 180 | + ), |
| 181 | + ): |
| 182 | + result = self.controller._login_redirect(self.portal_user.id) |
| 183 | + self.assertEqual(result, "/custom") |
| 184 | + |
| 185 | + def test_login_redirect_applies_custom_url_on_my_path(self): |
| 186 | + """Custom redirect applies when parent_redirect is /my""" |
| 187 | + mock_request = self._fake_request( |
| 188 | + self.portal_user, enabled=True, url="/special" |
| 189 | + ) |
| 190 | + with ( |
| 191 | + patch( |
| 192 | + "odoo.addons.website_user_login_redirect_custom.controllers.main.request", |
| 193 | + mock_request, |
| 194 | + ), |
| 195 | + patch( |
| 196 | + "odoo.addons.web.controllers.home.Home._login_redirect", |
| 197 | + return_value="/my", |
| 198 | + ), |
| 199 | + ): |
| 200 | + result = self.controller._login_redirect(self.portal_user.id) |
| 201 | + self.assertEqual(result, "/special") |
| 202 | + |
| 203 | + def test_login_redirect_returns_parent_when_no_custom_url(self): |
| 204 | + """Return parent redirect if no valid custom URL found""" |
| 205 | + mock_request = self._fake_request(self.portal_user, enabled=True, url=None) |
| 206 | + with ( |
| 207 | + patch( |
| 208 | + "odoo.addons.website_user_login_redirect_custom.controllers.main.request", |
| 209 | + mock_request, |
| 210 | + ), |
| 211 | + patch( |
| 212 | + "odoo.addons.web.controllers.home.Home._login_redirect", |
| 213 | + return_value="/my", |
| 214 | + ), |
| 215 | + ): |
| 216 | + result = self.controller._login_redirect(self.portal_user.id) |
| 217 | + self.assertEqual(result, "/my") |
0 commit comments