Skip to content

Commit d14dd0a

Browse files
committed
[FIX] website_user_login_redirect_custom: fix tests
Task: 5058
1 parent b4d9d6b commit d14dd0a

File tree

2 files changed

+0
-29
lines changed

2 files changed

+0
-29
lines changed

website_user_login_redirect_custom/tests/test_website_login_redirect.py

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -121,23 +121,3 @@ def test_check_url_format_skips_empty(self):
121121
"""_check_url_format should skip empty URLs"""
122122
settings = self.env["res.config.settings"].create({})
123123
settings._check_url_format() # Should not raise
124-
125-
def test_is_valid_redirect_url_rejects_external(self):
126-
"""Reject external URLs with scheme or domain"""
127-
settings = self.env["res.config.settings"].create({})
128-
self.assertFalse(settings.is_valid_redirect_url("http://evil.com"))
129-
130-
def test_check_url_format_raises_validation_error(self):
131-
"""Invalid URL triggers ValidationError during create"""
132-
with self.assertRaises(ValidationError):
133-
self.env["res.config.settings"].create(
134-
{"website_login_redirect_url": "javascript:alert(1)"}
135-
)
136-
137-
def test_onchange_strips_url_whitespace(self):
138-
"""Onchange removes leading/trailing spaces in URL"""
139-
settings = self.env["res.config.settings"].create(
140-
{"website_login_redirect_url": " /clean-me "}
141-
)
142-
settings._onchange_website_login_redirect_url()
143-
self.assertEqual(settings.website_login_redirect_url, "/clean-me")

website_user_login_redirect_custom/tests/test_website_login_redirect_controller.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -113,15 +113,6 @@ def test_get_custom_redirect_url(self):
113113
):
114114
self.assertFalse(self.controller._get_custom_redirect_url())
115115

116-
def test_should_redirect_custom_disabled(self):
117-
"""Feature disabled → no redirect should occur"""
118-
mock_request = self._fake_request(self.portal_user, enabled=False)
119-
with patch(
120-
"odoo.addons.website_user_login_redirect_custom.controllers.main.request",
121-
mock_request,
122-
):
123-
self.assertFalse(self.controller._should_redirect_custom())
124-
125116
def test_login_redirect_behavior(self):
126117
"""Verify custom redirect applies when feature enabled"""
127118
mock_request = self._fake_request(

0 commit comments

Comments
 (0)