[FIX] website_require_login: Disconnect notification on SQL error #1149
+57
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SirPyTech
force-pushed
the
14.0-fix-website_require_login-failed_transaction
branch
2 times, most recently
from
8ff4632 to
2e3deb4
Compare
How to reproduce the issue:
1. Create a CRON with code "env.cr.execute('SELECT not_a_field FROM res_users')"
2. Manually Execute the CRON
Expected behavior:
The Exception is shown in the UI
Actual behavior:
The "Disconnected" notification is briefly shown, and right after a "Connected" notification is shown
SirPyTech
force-pushed
the
14.0-fix-website_require_login-failed_transaction
branch
from
2e3deb4 to
d957657
Compare
Contributor
|
@OCA/website-maintainers can this be merged please? thanks! |
tarteo
reviewed
Dec 4, 2025
| # raised and the cursor is currently closed | ||
| try: | ||
| user = website.user_id | ||
| except OperationalError: |
Member
There was a problem hiding this comment.
Should OperationalError still be catched?
Member
|
/ocabot merge minor |
Contributor
|
What a great day to merge this nice PR. Let's do it! |
Contributor
|
Congratulations, your PR was merged at c12e358. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersede #1147 to resolve #1147 (review).
How to reproduce the issue:
Expected behavior:
The Exception is shown in the UI
Actual behavior:
The "Disconnected" notification is briefly shown, and right after a "Connected" notification is shown