Locations
| Sub-Issue |
File |
Line(s) |
| Siemens manufacturer typo |
siemens_base.py:17 |
"SIEMENS HEALHINEERS" → "SIEMENS HEALTHINEERS" |
| Enum filename typo |
enums/modaliy_enum.py |
File renamed to modality_enum.py |
| Wrong test URL path |
tests/test_report.py:26 |
/report/process/dicom → /api/report/process/dicom |
| Siemens base uses GE tags |
siemens_base.py:20-55 |
Replaced GE_* tags with SIEMENS_* tags |
| Siemens PLD uses GE tags |
siemens_basic_single_pld.py:18-21 |
Replaced GE_* tag references with local SIEMENS_* constants |
Description
Multiple typos, wrong paths, and copy-paste naming issues across the codebase. The most critical: the Siemens sequence classes used GE-specific DICOM tag names and references, including a comment saying "Direct GE-specific mappings" in Siemens code. The test file used a wrong URL path (missing /api prefix) causing it to always get a 404.
Reproduction (on main branch)
Buggy Code
Sub1: Siemens typo
# siemens_base.py:17
return "SIEMENS" in manufacturer or "SIEMENS HEALTHCARE" in manufacturer or "SIEMENS HEALHINEERS" in manufacturer
# ^^^^^^^^^^^^ typo
Sub2: Enum filename
enums/modaliy_enum.py # missing 't' → should be modality_enum.py
Sub3: Wrong test URL
# test_report.py:26
response = client.post("/report/process/dicom", ...) # Missing /api prefix!
Sub4-5: GE tags in Siemens code
# siemens_base.py:23-24
# Direct GE-specific mappings <-- Comment says GE!
if dcm_tags.GE_ASSET_R_FACTOR in d: <-- GE tag in Siemens code!
Automated Results on main branch
| # |
Test |
Status |
Detail |
| 1 |
Siemens manufacturer string correctly spelled |
FAIL |
Contains typo "HEALHINEERS" |
| 2 |
Enum file named modality_enum.py |
FAIL |
Named modaliy_enum.py |
| 3 |
Test uses correct URL /api/report/process/dicom |
FAIL |
Missing /api prefix |
| 4 |
siemens_base.py no GE-specific tags |
FAIL |
Contains GE_ASSET_R_FACTOR, GE_EFFECTIVE_ECHO_SPACING |
| 5 |
siemens_basic_single_pld.py no GE tags |
FAIL |
Uses GE_LABEL_DURATION, GE_INVERSION_TIME |
Summary: PASSED=0 FAILED=5
Working on this issue.
Locations
siemens_base.py:17"SIEMENS HEALHINEERS"→"SIEMENS HEALTHINEERS"enums/modaliy_enum.pymodality_enum.pytests/test_report.py:26/report/process/dicom→/api/report/process/dicomsiemens_base.py:20-55siemens_basic_single_pld.py:18-21Description
Multiple typos, wrong paths, and copy-paste naming issues across the codebase. The most critical: the Siemens sequence classes used GE-specific DICOM tag names and references, including a comment saying "Direct GE-specific mappings" in Siemens code. The test file used a wrong URL path (missing
/apiprefix) causing it to always get a 404.Reproduction (on
mainbranch)Buggy Code
Sub1: Siemens typo
Sub2: Enum filename
Sub3: Wrong test URL
Sub4-5: GE tags in Siemens code
Automated Results on
mainbranchmodality_enum.pymodaliy_enum.py/api/report/process/dicom/apiprefixsiemens_base.pyno GE-specific tagssiemens_basic_single_pld.pyno GE tagsSummary: PASSED=0 FAILED=5
Working on this issue.