Don't get a Field object for each plugin load

[olliestanley]

No description provided.

[Lunaphied]

Was this merged?
On Aug 14, 2014 7:40 AM, "Ollie" notifications@github.com wrote:

Closed #28 #28.

—
Reply to this email directly or view it on GitHub
#28 (comment).

[olliestanley]

nope - it was broken - see #29

[Lunaphied]

You know you can just update a PR right? Also are you on IRC?
On Aug 14, 2014 7:54 AM, "Ollie" notifications@github.com wrote:

nope - it was broken - see #29
#29

—
Reply to this email directly or view it on GitHub
#28 (comment).

[olliestanley]

Yes I know I can update a PR, but as the guidelines require one commit per PR it was easier to do a new one instead of messing around with squashing etc - and yes I'm on IRC (DziNeIT)

[Wolf480pl]

commit --amend

[olliestanley]

don't you then have to force push or something?

[Wolf480pl]

yeah, but force-pushing is fairly straightforward too.

[olliestanley]

yeah it's not hard, but in general i don't like force push. i guess it doesn't really apply to my own fork because nobody else is working on the fork at the same time but in general it can causes problems

[Lunaphied]

I only use force push to update my Fork's to the latest upstream master before I start working on a feature.

[olliestanley]

yeah but both squash and --amend require a force push