Fix: Backport PublishVelocityForceCommand unstamped twist/wrench XML to v9.3#662
Closed
JWhitleyWork wants to merge 1 commit into
Closed
Fix: Backport PublishVelocityForceCommand unstamped twist/wrench XML to v9.3#662JWhitleyWork wants to merge 1 commit into
JWhitleyWork wants to merge 1 commit into
Conversation
…mmand Backport of 9ff6820 from main to v9.3. Paired with moveit_pro #19304 cherry-picking ebf4b4b510 which exposes the unstamped twist/wrench ports on the C++ side. v9.3 needs both halves of the refactor or behavior trees fail to load on released 9.3.0-rcN images. For #19269.
Member
Author
|
This requires more changes than the single commit that Claude originally mentioned. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI integration tests for
lab_simagainst released9.3.0-rc9/9.3.0-rc10images fail in ~0.6s with:A paired refactor split across releases between this repo and
moveit_pro. The XML side (9ff6820fonmoveit_pro_example_ws/main, 2026-05-18) switched lab/kinova Objectives to the new unstampedtwist/wrenchports. The matching C++ side landed onmoveit_pro/mainbut missed the9.3.0-rc9andrc10cuts. Neither half is on v9.3.This PR backports the XML half. It is paired with PickNikRobotics/moveit_pro#19304 which backports the C++ half. Both halves must land together for
v9.3to be consistent; the C++ PR alone (with v9.3's old XML still wiringtwist_stamped) keeps working via the backwards-compat path, but landing this PR ahead of the C++ PR would break v9.3 CI the same way main broke when the workspace shipped first.For PickNikRobotics/moveit_pro#19269.
Alternatives considered
twist_stamped/wrench_stampedaccepted (deprecated but supported). Rejected because we want v9.3 and main to stay aligned at the Objective-XML level so backports and bisection don't keep tripping on the same diff.Chosen approach
Direct cherry-pick of
9ff6820fonto v9.3. One conflict invelocity_force_controller_zero.xml: v9.3 has unrelatedpublish_rate="10"andvelocity_force_controller_command_topicattributes that aren't on main. Resolved by keeping those v9.3-only attributes and applying thetwist=/wrench=port rename from the cherry-pick.Merge ordering
Merge PickNikRobotics/moveit_pro#19304 first (or together) so the next
v9.3image build has the new C++ ports before this XML lands. If this PR's CI uses an image_tag built after #19304 merges, it should go green.