diff --git a/changelog.d/cosmetic-metadata-fixes.fixed.md b/changelog.d/cosmetic-metadata-fixes.fixed.md new file mode 100644 index 000000000..403903061 --- /dev/null +++ b/changelog.d/cosmetic-metadata-fixes.fixed.md @@ -0,0 +1,2 @@ +- Fix `gov.dwp.tax_credits.min_benefit` parameter unit from `currency-USD` to `currency-GBP` — the parameter is a UK statutory threshold in pounds. +- Correct `benunit_weekly_hours` label from "Average weekly hours worked by adults in the benefit unit" to "Total weekly hours worked by adults in the benefit unit" — the formula is `adds = ["weekly_hours"]`, which sums rather than averages. diff --git a/policyengine_uk/parameters/gov/dwp/tax_credits/min_benefit.yaml b/policyengine_uk/parameters/gov/dwp/tax_credits/min_benefit.yaml index a1994abb6..363e315d7 100644 --- a/policyengine_uk/parameters/gov/dwp/tax_credits/min_benefit.yaml +++ b/policyengine_uk/parameters/gov/dwp/tax_credits/min_benefit.yaml @@ -7,6 +7,6 @@ metadata: reference: - href: https://www.legislation.gov.uk/uksi/2002/2008/regulation/9 name: The Tax Credits (Income Thresholds and Determination of Rates) Regulations 2002 - unit: currency-USD + unit: currency-GBP values: 2002-08-01: 26 diff --git a/policyengine_uk/tests/policy/baseline/finance/benefit/family/universal_credit/childcare_element/uc_childcare_element.yaml b/policyengine_uk/tests/policy/baseline/finance/benefit/family/universal_credit/childcare_element/uc_childcare_element.yaml index a6dd5eeb9..8df6e6a52 100644 --- a/policyengine_uk/tests/policy/baseline/finance/benefit/family/universal_credit/childcare_element/uc_childcare_element.yaml +++ b/policyengine_uk/tests/policy/baseline/finance/benefit/family/universal_credit/childcare_element/uc_childcare_element.yaml @@ -1,6 +1,6 @@ - name: No childcare, no element period: 2020 - absolute_error_margin: 0 + absolute_error_margin: 0.001 input: people: parent: @@ -15,7 +15,7 @@ - name: Childcare for one child under limit period: 2020 - absolute_error_margin: 0 + absolute_error_margin: 0.001 input: people: parent: @@ -30,7 +30,7 @@ - name: Childcare for one child over limit period: 2020 - absolute_error_margin: 0 + absolute_error_margin: 0.001 input: people: parent: diff --git a/policyengine_uk/tests/policy/baseline/finance/benefit/family/universal_credit/housing_costs_element/non_dep_deduction/uc_individual_non_dep_deduction.yaml b/policyengine_uk/tests/policy/baseline/finance/benefit/family/universal_credit/housing_costs_element/non_dep_deduction/uc_individual_non_dep_deduction.yaml index f0b64576c..1f7f3eada 100644 --- a/policyengine_uk/tests/policy/baseline/finance/benefit/family/universal_credit/housing_costs_element/non_dep_deduction/uc_individual_non_dep_deduction.yaml +++ b/policyengine_uk/tests/policy/baseline/finance/benefit/family/universal_credit/housing_costs_element/non_dep_deduction/uc_individual_non_dep_deduction.yaml @@ -1,6 +1,6 @@ - name: Fully liable period: 2020 - absolute_error_margin: 0 + absolute_error_margin: 0.001 input: people: person: @@ -15,7 +15,7 @@ - name: Exempt, no deduction period: 2020 - absolute_error_margin: 0 + absolute_error_margin: 0.001 input: people: person: @@ -30,7 +30,7 @@ - name: Too young, no deduction period: 2020 - absolute_error_margin: 0 + absolute_error_margin: 0.001 input: people: person: diff --git a/policyengine_uk/tests/policy/baseline/finance/benefit/family/universal_credit/income/uc_income_reduction.yaml b/policyengine_uk/tests/policy/baseline/finance/benefit/family/universal_credit/income/uc_income_reduction.yaml index 53de45886..81c934d57 100644 --- a/policyengine_uk/tests/policy/baseline/finance/benefit/family/universal_credit/income/uc_income_reduction.yaml +++ b/policyengine_uk/tests/policy/baseline/finance/benefit/family/universal_credit/income/uc_income_reduction.yaml @@ -1,6 +1,6 @@ - name: Reductions apply at correct rates period: 2021 - absolute_error_margin: 0 + absolute_error_margin: 0.001 input: uc_earned_income: 10 uc_unearned_income: 1 @@ -10,7 +10,7 @@ - name: Capped at max amount period: 2025 - absolute_error_margin: 0 + absolute_error_margin: 0.001 input: uc_earned_income: 1_000 uc_unearned_income: 400 @@ -20,7 +20,7 @@ - name: Uncapped at max amount period: 2025 - absolute_error_margin: 0 + absolute_error_margin: 0.001 input: uc_earned_income: 1_000 uc_unearned_income: 400 diff --git a/policyengine_uk/tests/policy/baseline/finance/income/minimum_wage.yaml b/policyengine_uk/tests/policy/baseline/finance/income/minimum_wage.yaml index c67046b5d..0c5878001 100644 --- a/policyengine_uk/tests/policy/baseline/finance/income/minimum_wage.yaml +++ b/policyengine_uk/tests/policy/baseline/finance/income/minimum_wage.yaml @@ -1,6 +1,6 @@ - name: Minimum wage for a person over 25 period: 2021 - absolute_error_margin: 0 + absolute_error_margin: 0.001 input: age: 30 output: @@ -8,7 +8,7 @@ - name: Minimum wage for a person aged 18 uses the 18 to 20 bracket period: 2025 - absolute_error_margin: 0 + absolute_error_margin: 0.001 input: age: 18 output: @@ -16,7 +16,7 @@ - name: Minimum wage for a person aged 21 uses the 21 to 22 bracket period: 2025 - absolute_error_margin: 0 + absolute_error_margin: 0.001 input: age: 21 output: @@ -24,7 +24,7 @@ - name: Minimum wage for a person aged 23 uses the 23 to 24 bracket period: 2025 - absolute_error_margin: 0 + absolute_error_margin: 0.001 input: age: 23 output: @@ -32,7 +32,7 @@ - name: Minimum wage for a person aged 25 uses the 25 or over bracket period: 2021 - absolute_error_margin: 0 + absolute_error_margin: 0.001 input: age: 25 output: diff --git a/policyengine_uk/variables/household/income/benunit_weekly_hours.py b/policyengine_uk/variables/household/income/benunit_weekly_hours.py index 140803bd0..6ac5bd74d 100644 --- a/policyengine_uk/variables/household/income/benunit_weekly_hours.py +++ b/policyengine_uk/variables/household/income/benunit_weekly_hours.py @@ -4,7 +4,7 @@ class benunit_weekly_hours(Variable): value_type = float entity = BenUnit - label = "Average weekly hours worked by adults in the benefit unit" + label = "Total weekly hours worked by adults in the benefit unit" definition_period = YEAR unit = "hour"