Some issues in Firefox 151 / WaveFox v1.9.151

[ethanwind]

Important clarification

• I have read and followed the installation instructions in the README

Describe the issue

The bookmark icons in the Firefox popup menu are misaligned, and the icons in the History and Bookmarks menu in the Firefox main menu are spaced too far from the text. Additionally, the toolbar is the same color as the program window instead of the standard Firefox color.

To reproduce

In about:config select WaveFox.Icons and assign the value 2, userChrome.Menu.Icons.Regular.Enabled to true, activate all the keys provided in the readme for custom icons:

• userChrome.icon.panel_full
• userChrome.icon.library
• userChrome.icon.panel
• userChrome.icon.menu
• userChrome.icon.context_menu
• userChrome.icon.global_menu
• userChrome.icon.1-25px_stroke
• userChrome.icon.account_image_to_right
• userChrome.icon.account_label_to_right
• userChrome.icon.menu.full
• userChrome.icon.global_menu.mac.

Not activated: userChrome.icon.panel_photon and userChrome.icon.global_menubar.

Furthermore, the Firefox toolbar, as you can see, is the same color as the main program window.

The result is in the following images:

Expected behavior

The different behavior occurred with the new version of Firefox (v.151) and WaveFox v.1.9.151. There were no problems with the previous version of the browser and the previous WaveFox.

Additional information

I tried making some rough changes to the WaveFox files and managed to clumsily fix the problems.

Regarding the color, I neutralized with "/* ... */" in notepad the lines from 173 to 188 of the wavefox_tabs file in the horizontal_tabs folder, specifically the section titled "Floating Tabs".

As for the icons, I neutralized lines 1145, 1146, 1159, 1160, 1216, 1217, 1230 and 1231 (the "#historyMenuPopup" and "#bookmarksMenuPopup" entries) in the main menu using Notepad "/* ... */."

Furthermore, for the Firefox bookmarks popup menu, I neutralized lines 1391 to 1397, just below the "/* Bookmark Popup - None icon menu */" index in "Firefox-UI-Fix_icons" file.

I repeat, these are crude changes and not at all precise and adequate, but now the program is back to how it was before.

I would be so much grateful if you may investigate this issues and adopt the necessary changes.
Thank you.

Operating system

Windows 11

Color scheme

• System
• Light
• Dark
• Contrast

Firefox version

Developer

Firefox theme

• System / Auto
• Light
• Dark
• Repository / AMO

WaveFox version

Release

[QNetITQ]

Okay. I'll see what I can do.

[ethanwind]

Thank you so much.

[QNetITQ]

The icons will be updated, but I don't know if this will help. I won't fix it myself. This isn't my code, and it's so poorly written that I won't even waste time figuring it out.

The browser toolbar background color was removed on purpose, so it's a feature, not a bug. If you think this is a bad solution, then clarify what would be more optimal for visual navigation between the toolbars. Is it better to keep the default background or make it the same as the active tab? Please formulate a precise request.

[ethanwind]

First of all, thank you for your time and your reply.
I hope that the icons update will fix the issue. Anyway my poor solution has, for now, resolved the problem.
I think, mostly for darker colors of tabs, that it would be better to think about an option to let the user choose if to use the browser toolbar background or not.
Anyway, thanks again for your help.

[QNetITQ]

Here are some options for how this can be implemented. The important thing is that it be convenient and not annoying. Choose the optimal one.

[ethanwind]

I'm not the right person to tell the way you should implement your software, so I won't choose any of the options you gave.
For me, and only for me, I would like to keep on using WaveFox as in version .150.
My tabs background and toolbar background are in this way:

---

Thank you.

[QNetITQ]

I've updated the icons. Regarding the toolbar background, I'd prefer to leave it as is, as the current implementation is compatible with all modes and supports system transparency. I'll likely just limit this feature to the system theme. Then your AMO theme will display as the author intended. But I'll need to think about that further before making a final decision.

[ethanwind]

I've tried the new files. Now the bookmark icons in the Firefox popup menu are still misaligned (anyway a bit better than before), while the icons in the History and Bookmarks menu in the Firefox main menu are fixed. I really appreciate this upgrade. Don't mind for my second request: this software is not intended only for my personal purposes, so I do perfectly understand your point of view.
Thanks so much.