Skip to content

Conversation

@Phoenix616
Copy link

@Phoenix616 Phoenix616 commented Dec 6, 2025

This fixes some issues in the German translation:

  • The "back" button in the menu was translated with the German word for the body part "back" instead of the one for "going backwards"
  • Grammatical error in the XSS warning message
  • Fix non-full German translation in unreadMention_plural

Summary by CodeRabbit

  • Chores
    • Updated German language translations for improved messaging accuracy and consistency throughout the user interface, including refinements to menu labels, notification text, and descriptive content.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 6, 2025

Walkthrough

German language translation file updated with corrections and improvements. Menu back button translation revised, self-XSS description reworded for clarity, and unread mention notifications translated from English to German.

Changes

Cohort / File(s) Summary
German Localization Updates
src/i18n/de-DE.i18n.json
Updated German translations: menu back button ("&Der Rücken" → "&Zurück"), self-XSS description reworded with corrected quoting, and unread mention/direct message plural tooltip translated to German. Trailing whitespace adjusted.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Translation strings are straightforward text updates with no logic changes
  • Single file modification makes scope minimal
  • Verify translations are accurate German and context-appropriate
  • Confirm template variables (e.g., {{- count}}) remain intact in tooltip strings

Poem

🐰 A rabbit hops through languages bright,
German words now perfectly right,
From "&Der Rücken" to "&Zurück" we spring,
Translations polished—a localization thing! 🌍✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main change: fixing issues in German translations across multiple keys (menu back button, XSS message, and unread mentions).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 3b1c7c3 and 4c80d1e.

📒 Files selected for processing (1)
  • src/i18n/de-DE.i18n.json (4 hunks)
🔇 Additional comments (2)
src/i18n/de-DE.i18n.json (2)

284-284: LGTM!

The menu back button translation is now correct, using the navigation term "&Zurück" instead of the body part "&Der Rücken". This is the appropriate German word for the back/navigate-backwards action.


375-375: LGTM!

The unread mention plural notification is now properly translated to German: "Sie haben {{- count}} ungelesene Erwähnungen/Direktnachrichten". The placeholder syntax and grammar are correct.

Comment on lines +347 to 348
"description": "Dies ist eine Browserfunktion, die für Entwickler gedacht ist. Wenn Ihnen jemand gesagt hat, dass Sie hier etwas kopieren und einfügen sollen, um eine Rocket.Chat-Funktion zu aktivieren oder um das Konto einer anderen Person zu \"hacken\" , ist dies ein Betrug und verschafft dieser Person Zugriff auf Ihr Rocket.Chat-Konto.",
"moreInfo": "Weitere Informationen finden Sie unter https://go.rocket.chat/i/xss."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

cat -n src/i18n/de-DE.i18n.json | sed -n '345,350p'

Repository: RocketChat/Rocket.Chat.Electron

Length of output: 206


🏁 Script executed:

find . -name "de-DE.i18n.json" -type f

Repository: RocketChat/Rocket.Chat.Electron

Length of output: 206


Fix German punctuation spacing in selfxss description.

The text contains \"hacken\" , with an incorrect space before the comma. In German, punctuation marks should not be preceded by a space. Change to \"hacken\", (no space before comma).

🤖 Prompt for AI Agents
In src/i18n/de-DE.i18n.json around lines 347 to 348, the German sentence
contains an incorrect space before the comma in `\"hacken\" ,`; remove the
extraneous space so the comma directly follows the closing quote (`\"hacken\",`)
to conform to German punctuation rules.

@CLAassistant
Copy link

CLAassistant commented Dec 6, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants