-
Notifications
You must be signed in to change notification settings - Fork 785
fix: Issues in German translation #3155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughGerman language translation file updated with corrections and improvements. Menu back button translation revised, self-XSS description reworded for clarity, and unread mention notifications translated from English to German. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
src/i18n/de-DE.i18n.json(4 hunks)
🔇 Additional comments (2)
src/i18n/de-DE.i18n.json (2)
284-284: LGTM!The menu back button translation is now correct, using the navigation term "&Zurück" instead of the body part "&Der Rücken". This is the appropriate German word for the back/navigate-backwards action.
375-375: LGTM!The unread mention plural notification is now properly translated to German: "Sie haben {{- count}} ungelesene Erwähnungen/Direktnachrichten". The placeholder syntax and grammar are correct.
| "description": "Dies ist eine Browserfunktion, die für Entwickler gedacht ist. Wenn Ihnen jemand gesagt hat, dass Sie hier etwas kopieren und einfügen sollen, um eine Rocket.Chat-Funktion zu aktivieren oder um das Konto einer anderen Person zu \"hacken\" , ist dies ein Betrug und verschafft dieser Person Zugriff auf Ihr Rocket.Chat-Konto.", | ||
| "moreInfo": "Weitere Informationen finden Sie unter https://go.rocket.chat/i/xss." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
cat -n src/i18n/de-DE.i18n.json | sed -n '345,350p'Repository: RocketChat/Rocket.Chat.Electron
Length of output: 206
🏁 Script executed:
find . -name "de-DE.i18n.json" -type fRepository: RocketChat/Rocket.Chat.Electron
Length of output: 206
Fix German punctuation spacing in selfxss description.
The text contains \"hacken\" , with an incorrect space before the comma. In German, punctuation marks should not be preceded by a space. Change to \"hacken\", (no space before comma).
🤖 Prompt for AI Agents
In src/i18n/de-DE.i18n.json around lines 347 to 348, the German sentence
contains an incorrect space before the comma in `\"hacken\" ,`; remove the
extraneous space so the comma directly follows the closing quote (`\"hacken\",`)
to conform to German punctuation rules.
This fixes some issues in the German translation:
unreadMention_pluralSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.