remove acceptRoomInvite from Room service

Author: sampaiodiego

apps/meteor/app/lib/server/functions/acceptRoomInvite.ts

@@ -18,9 +18,7 @@ export const performAcceptRoomInvite = async (
 	user: IUser & { username: string },
 ): Promise<void> => {
 	if (subscription.status !== 'INVITED') {
-		throw new Meteor.Error('error-not-invited', 'User was not invited to this room', {
-			method: 'acceptRoomInvite',
-		});
+		throw new Meteor.Error('error-not-invited', 'User was not invited to this room');
 	}
 
 	await callbacks.run('beforeJoinRoom', user, room);

apps/meteor/app/lib/server/functions/addUserToRoom.ts

@@ -143,7 +143,6 @@ export const performAddUserToRoom = async (
 		}
 	}
 
-
 	if (room.teamMain && room.teamId) {
 		await Team.addMember(inviter || userToBeAdded, userToBeAdded._id, room.teamId);
 	}

apps/meteor/server/services/room/service.ts

@@ -7,7 +7,7 @@ import { Rooms, Subscriptions, Users } from '@rocket.chat/models';
 import { FederationActions } from './hooks/BeforeFederationActions';
 import { saveRoomName } from '../../../app/channel-settings/server';
 import { saveRoomTopic } from '../../../app/channel-settings/server/functions/saveRoomTopic';
-import { acceptRoomInvite, performAcceptRoomInvite } from '../../../app/lib/server/functions/acceptRoomInvite';
+import { performAcceptRoomInvite } from '../../../app/lib/server/functions/acceptRoomInvite';
 import { addUserToRoom, performAddUserToRoom } from '../../../app/lib/server/functions/addUserToRoom';
 import { createRoom } from '../../../app/lib/server/functions/createRoom'; // TODO remove this import
 import { removeUserFromRoom, performUserRemoval } from '../../../app/lib/server/functions/removeUserFromRoom';
@@ -102,10 +102,6 @@ export class RoomService extends ServiceClassInternal implements IRoomService {
 		return performUserRemoval(roomId, user, options);
 	}
 
-	async acceptRoomInvite(room: IRoom, subscription: ISubscription, user: IUser & { username: string }): Promise<void> {
-		return acceptRoomInvite(room, subscription, user);
-	}
-
 	async performAcceptRoomInvite(room: IRoom, subscription: ISubscription, user: IUser & { username: string }): Promise<void> {
 		return performAcceptRoomInvite(room, subscription, user);
 	}

apps/meteor/tests/data/rooms.helper.ts

@@ -452,4 +452,4 @@ export const acceptRoomInvite = (roomId: IRoom['_id'], config?: IRequestConfig)
 				resolve(req.body);
 			});
 	});
-};
+};

packages/core-services/src/types/IRoomService.ts

@@ -57,7 +57,6 @@ export interface IRoomService {
 	): Promise<boolean | undefined>;
 	removeUserFromRoom(roomId: string, user: IUser, options?: { byUser: Pick<IUser, '_id' | 'username'> }): Promise<void>;
 	performUserRemoval(roomId: string, user: IUser, options?: { byUser?: IUser }): Promise<void>;
-	acceptRoomInvite(room: IRoom, subscription: ISubscription, user: IUser): Promise<void>;
 	performAcceptRoomInvite(room: IRoom, subscription: ISubscription, user: IUser): Promise<void>;
 	getValidRoomName(displayName: string, roomId?: string, options?: { allowDuplicates?: boolean }): Promise<string>;
 	saveRoomTopic(