Skip to content

Conversation

@sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Dec 5, 2025

Proposed changes (including videos or screenshots)

We were completely missing the errors the way we were logging errors.

See this code as an example of why the changes are needed:

const lero = new Logger('lero');
try {
	const foo = { a: 1, b: 2 };
	const bar = 'some string';

	lero.warn('foo wrong', foo);
	lero.warn({ foo, msg: 'foo correct' });

	lero.warn('bar wrong', bar);
	lero.warn({ bar, msg: 'bar correct' });

	// @ts-ignore
	console.log(xxx);
} catch (error) {
	lero.error('wrong error:', error);
	lero.error(error, 'correct error');
}

This produces the following production logs:

{"level":40,"time":"2025-12-05T18:33:54.867Z","pid":86382,"hostname":"local","name":"lero","msg":"foo wrong {\"a\":1,\"b\":2}"}
{"level":40,"time":"2025-12-05T18:33:54.867Z","pid":86382,"hostname":"local","name":"lero","foo":{"a":1,"b":2},"msg":"foo correct"}
{"level":40,"time":"2025-12-05T18:33:54.867Z","pid":86382,"hostname":"local","name":"lero","msg":"bar wrong 'some string'"}
{"level":40,"time":"2025-12-05T18:33:54.867Z","pid":86382,"hostname":"local","name":"lero","bar":"some string","msg":"bar correct"}
{"level":50,"time":"2025-12-05T18:33:54.867Z","pid":86382,"hostname":"local","name":"lero","msg":"wrong error: {}"}
{"level":50,"time":"2025-12-05T18:33:54.867Z","pid":86382,"hostname":"local","name":"lero","err":{"type":"ReferenceError","message":"xxx is not defined","stack":"ReferenceError: xxx is not defined\n    at Object.<anonymous> (/Users/diegosampaio/dev/Rocket.Chat/ee/packages/federation-matrix/src/FederationMatrix.ts:149:14)\n    at Module.<anonymous> (node:internal/modules/cjs/loader:1688:14)\n    at Module.Mp._compile (/tools/static-assets/server/runtime.js:91:21)\n    at Object.Module._extensions..js (/tools/static-assets/server/runtime.js:125:21)\n    at Module.<anonymous> (node:internal/modules/cjs/loader:1423:32)\n    at Module.Mp.load (/tools/static-assets/server/runtime.js:35:31)\n    at Function._load (node:internal/modules/cjs/loader:1246:12)\n    at TracingChannel.traceSync (node:diagnostics_channel:322:14)\n    at wrapModuleLoad (node:internal/modules/cjs/loader:235:24)\n    at Module.<anonymous> (node:internal/modules/cjs/loader:1445:12)\n    at Module.mod.require (/Users/diegosampaio/.meteor/packages/meteor-tool/.3.3.1.1ppfc33ygtz++os.osx.arm64+web.browser+web.browser.legacy+web.cordova/mt-os.osx.arm64/dev_bundle/server-lib/node_modules/@meteorjs/reify/lib/runtime/index.js:30:33)\n    at require (node:internal/modules/helpers:135:16)\n    at Object.<anonymous> (/Users/diegosampaio/dev/Rocket.Chat/ee/packages/federation-matrix/src/index.ts:3:1)\n    at Module.<anonymous> (node:internal/modules/cjs/loader:1688:14)\n    at Module.Mp._compile (/tools/static-assets/server/runtime.js:91:21)\n    at Object.Module._extensions..js (/tools/static-assets/server/runtime.js:125:21)"},"msg":"correct error"}

as you can see this is what we were seeing: "msg":"wrong error: {}"}

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

  • Refactor
    • Standardized error logging patterns across federation services with improved structured logging for enhanced consistency and observability in error handling.

✏️ Tip: You can customize this high-level summary in your review settings.

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Dec 5, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2025

⚠️ No Changeset found

Latest commit: 4301ee0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 5, 2025

Walkthrough

This PR standardizes error logging patterns across the federation-matrix package by converting logger.error calls from message-first to error-first argument ordering and replacing plain string logs with structured log objects containing contextual identifiers and message fields.

Changes

Cohort / File(s) Summary
Event handlers
ee/packages/federation-matrix/src/events/edu.ts, ee/packages/federation-matrix/src/events/member.ts, ee/packages/federation-matrix/src/events/message.ts, ee/packages/federation-matrix/src/events/reaction.ts
Swapped error logging argument order from (message, error) to (error, message); replaced plain string error messages with structured log objects containing identifiers and msg fields
Core federation
ee/packages/federation-matrix/src/FederationMatrix.ts
Standardized error logging across try-catch blocks by swapping argument order and converting to structured log objects with contextual fields (roomId, messageId, etc.)
API layer
ee/packages/federation-matrix/src/api/_matrix/invite.ts
Converted logger.error invocations in runWithBackoff retry logic to pass error object first, followed by descriptive message string
Media service
ee/packages/federation-matrix/src/services/MatrixMediaService.ts
Standardized logging across file handling paths by inverting error argument order and introducing structured objects for invalid MXC URI contexts

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10–15 minutes

  • Rationale: Changes follow a consistent, homogeneous pattern across multiple files (argument order swap + structured logging) with no functional or control-flow alterations. Repetitive nature of edits reduces per-file review complexity despite the 7-file spread.

Possibly related PRs

  • RocketChat/Rocket.Chat#37116: Modifies runWithBackoff-related code and logging in the same invite.ts file; complements this PR's logging standardization in retry logic.
  • RocketChat/Rocket.Chat#37035: Related federation-matrix logging and API standardization changes across the same event and service files.

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

  • rodrigok
  • ggazzo
  • ricardogarim

Poem

🐰 Logs now tell their tales so bright,
Errors first, then messages light,
Structured fields dance in the night,
Federation's logging—finally right! ✨📝

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore(federation): fix error logs' is directly related to the main change: the PR fixes error logging by correcting the argument order in logger.error() calls across multiple federation files.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore-federation-error-logs

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 48953d2 and 4301ee0.

📒 Files selected for processing (7)
  • ee/packages/federation-matrix/src/FederationMatrix.ts (16 hunks)
  • ee/packages/federation-matrix/src/api/_matrix/invite.ts (1 hunks)
  • ee/packages/federation-matrix/src/events/edu.ts (2 hunks)
  • ee/packages/federation-matrix/src/events/member.ts (1 hunks)
  • ee/packages/federation-matrix/src/events/message.ts (5 hunks)
  • ee/packages/federation-matrix/src/events/reaction.ts (3 hunks)
  • ee/packages/federation-matrix/src/services/MatrixMediaService.ts (5 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx,js}

📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)

**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation

Files:

  • ee/packages/federation-matrix/src/api/_matrix/invite.ts
  • ee/packages/federation-matrix/src/events/member.ts
  • ee/packages/federation-matrix/src/services/MatrixMediaService.ts
  • ee/packages/federation-matrix/src/events/message.ts
  • ee/packages/federation-matrix/src/events/reaction.ts
  • ee/packages/federation-matrix/src/events/edu.ts
  • ee/packages/federation-matrix/src/FederationMatrix.ts
🧠 Learnings (4)
📓 Common learnings
Learnt from: ricardogarim
Repo: RocketChat/Rocket.Chat PR: 37377
File: apps/meteor/ee/server/hooks/federation/index.ts:86-88
Timestamp: 2025-11-04T16:49:19.107Z
Learning: In Rocket.Chat's federation system (apps/meteor/ee/server/hooks/federation/), permission checks follow two distinct patterns: (1) User-initiated federation actions (creating rooms, adding users to federated rooms, joining from invites) should throw MeteorError to inform users they lack 'access-federation' permission. (2) Remote server-initiated federation events should silently skip/ignore when users lack permission. The beforeAddUserToRoom hook only executes for local user-initiated actions, so throwing an error there is correct. Remote federation events are handled separately by the federation Matrix package with silent skipping logic.
📚 Learning: 2025-10-28T16:53:42.761Z
Learnt from: ricardogarim
Repo: RocketChat/Rocket.Chat PR: 37205
File: ee/packages/federation-matrix/src/FederationMatrix.ts:296-301
Timestamp: 2025-10-28T16:53:42.761Z
Learning: In the Rocket.Chat federation-matrix integration (ee/packages/federation-matrix/), the createRoom method from rocket.chat/federation-sdk will support a 4-argument signature (userId, roomName, visibility, displayName) in newer versions. Code using this 4-argument call is forward-compatible with planned library updates and should not be flagged as an error.

Applied to files:

  • ee/packages/federation-matrix/src/api/_matrix/invite.ts
  • ee/packages/federation-matrix/src/FederationMatrix.ts
📚 Learning: 2025-11-04T16:49:19.107Z
Learnt from: ricardogarim
Repo: RocketChat/Rocket.Chat PR: 37377
File: apps/meteor/ee/server/hooks/federation/index.ts:86-88
Timestamp: 2025-11-04T16:49:19.107Z
Learning: In Rocket.Chat's federation system (apps/meteor/ee/server/hooks/federation/), permission checks follow two distinct patterns: (1) User-initiated federation actions (creating rooms, adding users to federated rooms, joining from invites) should throw MeteorError to inform users they lack 'access-federation' permission. (2) Remote server-initiated federation events should silently skip/ignore when users lack permission. The beforeAddUserToRoom hook only executes for local user-initiated actions, so throwing an error there is correct. Remote federation events are handled separately by the federation Matrix package with silent skipping logic.

Applied to files:

  • ee/packages/federation-matrix/src/events/edu.ts
  • ee/packages/federation-matrix/src/FederationMatrix.ts
📚 Learning: 2025-09-19T15:15:04.642Z
Learnt from: rodrigok
Repo: RocketChat/Rocket.Chat PR: 36991
File: apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts:219-221
Timestamp: 2025-09-19T15:15:04.642Z
Learning: The Federation_Matrix_homeserver_domain setting in apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts is part of the old federation system and is being deprecated/removed, so configuration issues with this setting should not be flagged for improvement.

Applied to files:

  • ee/packages/federation-matrix/src/FederationMatrix.ts
🧬 Code graph analysis (4)
ee/packages/federation-matrix/src/api/_matrix/invite.ts (1)
ee/packages/media-calls/src/logger.ts (1)
  • logger (3-3)
ee/packages/federation-matrix/src/events/member.ts (1)
ee/packages/media-calls/src/logger.ts (1)
  • logger (3-3)
ee/packages/federation-matrix/src/services/MatrixMediaService.ts (1)
ee/packages/media-calls/src/logger.ts (1)
  • logger (3-3)
ee/packages/federation-matrix/src/events/message.ts (1)
ee/packages/media-calls/src/logger.ts (1)
  • logger (3-3)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (15)
  • GitHub Check: 🔨 Test UI (EE) / MongoDB 5.0 (5/5)
  • GitHub Check: 🔨 Test UI (EE) / MongoDB 5.0 (4/5)
  • GitHub Check: 🔨 Test UI (EE) / MongoDB 5.0 (3/5)
  • GitHub Check: 🔨 Test UI (EE) / MongoDB 5.0 (1/5)
  • GitHub Check: 🔨 Test UI (EE) / MongoDB 5.0 (2/5)
  • GitHub Check: 🔨 Test API (EE) / MongoDB 8.2 coverage (1/1)
  • GitHub Check: 🔨 Test UI (EE) / MongoDB 8.2 [legacy watchers] coverage (5/5)
  • GitHub Check: 🔨 Test API (EE) / MongoDB 5.0 (1/1)
  • GitHub Check: 🔨 Test UI (EE) / MongoDB 8.2 [legacy watchers] coverage (3/5)
  • GitHub Check: 🔨 Test UI (EE) / MongoDB 8.2 [legacy watchers] coverage (1/5)
  • GitHub Check: 🔨 Test UI (EE) / MongoDB 8.2 [legacy watchers] coverage (2/5)
  • GitHub Check: 🔨 Test UI (CE) / MongoDB 8.2 (2/4)
  • GitHub Check: 🔨 Test UI (EE) / MongoDB 8.2 [legacy watchers] coverage (4/5)
  • GitHub Check: 🔨 Test UI (CE) / MongoDB 8.2 (4/4)
  • GitHub Check: 🔨 Test UI (CE) / MongoDB 8.2 (1/4)
🔇 Additional comments (39)
ee/packages/federation-matrix/src/api/_matrix/invite.ts (2)

146-151: LGTM! Error logging pattern corrected.

The changes properly swap the argument order to logger.error(error, message), ensuring errors are logged with full stack traces instead of appearing as empty objects in production logs.


407-407: LGTM! Structured error logging pattern is correct.

The structured logging format with { msg, err } properly includes the error object, ensuring stack traces are captured in production logs.

ee/packages/federation-matrix/src/events/member.ts (1)

101-101: LGTM! Error logging pattern corrected.

The error-first argument order ensures the error object is properly serialized with stack trace information in production logs.

ee/packages/federation-matrix/src/events/edu.ts (2)

30-30: LGTM! Error logging pattern corrected.

The error-first argument order ensures proper error serialization with stack traces in production logs.


82-82: LGTM! Error logging pattern corrected.

The error-first argument order ensures proper error serialization with stack traces in production logs.

ee/packages/federation-matrix/src/events/message.ts (7)

167-167: LGTM! Structured error logging provides context.

The structured logging format includes the relevant event_id for debugging while ensuring the error message is properly logged.


219-219: LGTM! Structured error logging provides context.

The structured logging format includes the relevant quoteMessageEventId for debugging while ensuring the error message is properly logged.


270-270: LGTM! Error logging pattern corrected.

The error-first argument order ensures proper error serialization with stack traces in production logs.


314-314: LGTM! Structured error logging provides context.

The structured logging format includes the relevant event_id for debugging while ensuring the error message is properly logged.


357-357: LGTM! Structured error logging provides context.

The structured logging format includes the relevant quoteMessageEventId for debugging while ensuring the error message is properly logged.


384-384: LGTM! Error logging pattern corrected.

The error-first argument order ensures proper error serialization with stack traces in production logs.


416-416: LGTM! Error logging pattern corrected.

The error-first argument order ensures proper error serialization with stack traces in production logs.

ee/packages/federation-matrix/src/events/reaction.ts (4)

20-20: LGTM! Structured error logging provides context.

The structured logging format includes the invalid sender value for debugging while ensuring the error message is properly logged.


27-27: LGTM! Structured error logging provides context.

The structured logging format includes relevant identifiers (reactionTargetEventId, internalUsername) for debugging while ensuring the error message is properly logged.


46-46: LGTM! Error logging pattern corrected.

The error-first argument order ensures proper error serialization with stack traces in production logs.


90-90: LGTM! Error logging pattern corrected.

The error-first argument order ensures proper error serialization with stack traces in production logs.

ee/packages/federation-matrix/src/services/MatrixMediaService.ts (5)

26-26: LGTM! Structured error logging provides context.

The structured logging format includes the invalid mxcUri value for debugging while ensuring the error message is properly logged.


58-58: LGTM! Error logging pattern corrected.

The error-first argument order ensures proper error serialization with stack traces in production logs.


77-77: LGTM! Error logging pattern corrected.

The error-first argument order ensures proper error serialization with stack traces in production logs.


97-97: LGTM! Structured error logging provides context.

The structured logging format includes the invalid mxcUri value for debugging while ensuring the error message is properly logged.


133-133: LGTM! Error logging pattern corrected.

The error-first argument order ensures proper error serialization with stack traces in production logs.

ee/packages/federation-matrix/src/FederationMatrix.ts (18)

240-240: LGTM! Error logging pattern corrected.

The error-first argument order ensures proper error serialization with stack traces in production logs.


263-263: LGTM! Error logging pattern corrected.

The error-first argument order ensures proper error serialization with stack traces in production logs.


314-314: LGTM! Error logging pattern corrected.

The error-first argument order ensures proper error serialization with stack traces in production logs.


323-323: LGTM! Structured logging provides context.

The structured logging format includes the roomId for debugging while ensuring the message is properly logged.


325-325: LGTM! Error logging pattern corrected.

The error-first argument order ensures proper error serialization with stack traces in production logs.


379-383: LGTM! Structured error logging provides rich context.

The structured logging format includes both the messageId and error object, ensuring full debugging context and proper error serialization in production logs.


477-477: LGTM! Error logging pattern corrected.

The error-first argument order ensures proper error serialization with stack traces in production logs.


539-539: LGTM! Error logging pattern corrected.

The error-first argument order ensures proper error serialization with stack traces in production logs.


575-575: LGTM! Error logging pattern corrected.

The error-first argument order ensures proper error serialization with stack traces in production logs.


610-610: LGTM! Structured logging provides context.

The structured logging format includes the eventId for debugging while ensuring the message is properly logged.


612-612: LGTM! Error logging pattern corrected.

The error-first argument order ensures proper error serialization with stack traces in production logs.


621-621: LGTM! Structured error logging provides context.

The structured logging format includes the messageId for debugging while ensuring the error message is properly logged.


633-633: LGTM! Structured error logging provides context.

The structured logging format includes the room ID (rid) for debugging while ensuring the error message is properly logged.


666-666: LGTM! Error logging pattern corrected.

The error-first argument order ensures proper error serialization with stack traces in production logs.


694-694: LGTM! Error logging pattern corrected.

The error-first argument order ensures proper error serialization with stack traces in production logs.


718-718: LGTM! Error logging pattern corrected.

The error-first argument order ensures proper error serialization with stack traces in production logs.


732-732: LGTM! Structured error logging provides context.

The structured logging format includes the userId for debugging while ensuring the error message is properly logged.


753-753: LGTM! Error logging pattern corrected.

The error-first argument order ensures proper error serialization with stack traces in production logs.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

📦 Docker Image Size Report

📈 Changes

Service Current Baseline Change Percent
sum of all images 1.2GiB 1.2GiB +12MiB
rocketchat 359MiB 347MiB +12MiB
omnichannel-transcript-service 132MiB 132MiB -239B
queue-worker-service 132MiB 132MiB +108B
ddp-streamer-service 126MiB 126MiB -801B
account-service 113MiB 113MiB +1.6KiB
stream-hub-service 111MiB 111MiB -504B
authorization-service 111MiB 111MiB +1.0KiB
presence-service 111MiB 111MiB +754B

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/15 22:28", "11/16 01:28", "11/17 23:50", "11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 23:01", "12/02 21:57", "12/03 21:00", "12/04 18:17", "12/05 15:23", "12/05 18:55 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "queue-worker-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "rocketchat" [0.36, 0.36, 0.35, 0.35, 0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.35]
  line "stream-hub-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
Loading

Statistics (last 14 days):

  • 📊 Average: 1.5GiB
  • ⬇️ Minimum: 1.2GiB
  • ⬆️ Maximum: 1.6GiB
  • 🎯 Current PR: 1.2GiB
ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

  • Tag: pr-37706
  • Baseline: develop
  • Timestamp: 2025-12-05 18:55:57 UTC
  • Historical data points: 14

Updated: Fri, 05 Dec 2025 18:55:57 GMT

@sampaiodiego sampaiodiego force-pushed the chore-federation-error-logs branch from 5ffdd08 to 4301ee0 Compare December 5, 2025 18:42
@sampaiodiego sampaiodiego marked this pull request as ready for review December 5, 2025 19:09
@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.78%. Comparing base (75bd3e4) to head (4301ee0).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #37706      +/-   ##
===========================================
- Coverage    67.89%   67.78%   -0.11%     
===========================================
  Files         3449     3449              
  Lines       114020   114030      +10     
  Branches     20956    20963       +7     
===========================================
- Hits         77410    77292     -118     
- Misses       34491    34627     +136     
+ Partials      2119     2111       -8     
Flag Coverage Δ
e2e 57.22% <ø> (-0.08%) ⬇️
e2e-api 42.13% <ø> (-1.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants