Skip to content

Commit 7b74390

Browse files
zbennett10SBoudrias
authored andcommitted
replaced deprecated gulp-util and fixed broken test (#129)
1 parent 1e3adcb commit 7b74390

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

index.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,11 @@ var checker = require('istanbul-threshold-checker');
66
// Make sure istanbul is `require`d after the istanbul-threshold-checker to use the istanbul version
77
// defined in this package.json instead of the one defined in istanbul-threshold-checker.
88
var istanbul = require('istanbul');
9-
var gutil = require('gulp-util');
109
var _ = require('lodash');
1110
var applySourceMap = require('vinyl-sourcemaps-apply');
1211
var Report = istanbul.Report;
1312
var Collector = istanbul.Collector;
14-
var PluginError = gutil.PluginError;
13+
var PluginError = require('plugin-error');
1514

1615
var PLUGIN_NAME = 'gulp-istanbul';
1716
var COVERAGE_VARIABLE = '$$cov_' + new Date().getTime() + '$$';

package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@
2828
"test": "mocha -R spec"
2929
},
3030
"dependencies": {
31-
"gulp-util": "^3.0.1",
3231
"istanbul": "^0.4.0",
3332
"istanbul-threshold-checker": "^0.2.1",
3433
"lodash": "^4.0.0",
34+
"plugin-error": "^0.1.2",
3535
"through2": "^2.0.0",
3636
"vinyl-sourcemaps-apply": "^0.2.1"
3737
},
@@ -42,7 +42,8 @@
4242
"isparta": "^4.0.0",
4343
"jshint": "^2.5.0",
4444
"mocha": "^4.0.0",
45-
"rimraf": "^2.2.8"
45+
"rimraf": "^2.2.8",
46+
"vinyl": "^2.1.0"
4647
},
4748
"license": "MIT"
4849
}

test/main.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
var fs = require('fs');
44
var assert = require('assert');
55
var rimraf = require('rimraf');
6-
var gutil = require('gulp-util');
6+
var File = require('vinyl');
77
var gulp = require('gulp');
88
var istanbul = require('../');
99
var isparta = require('isparta');
@@ -26,7 +26,7 @@ describe('gulp-istanbul', function () {
2626
describe('istanbul()', function () {
2727
beforeEach(function () {
2828
this.stream = istanbul();
29-
libFile = new gutil.File({
29+
libFile = new File({
3030
path: 'test/fixtures/lib/add.js',
3131
cwd: 'test/',
3232
base: 'test/fixtures/lib',
@@ -48,7 +48,7 @@ describe('gulp-istanbul', function () {
4848
});
4949

5050
it('throw when receiving a stream', function (done) {
51-
var srcFile = new gutil.File({
51+
var srcFile = new File({
5252
path: path.join('test', 'fixtures', 'lib', 'add.js'),
5353
cwd: 'test/',
5454
base: 'test/fixtures/lib',
@@ -65,7 +65,7 @@ describe('gulp-istanbul', function () {
6565
});
6666

6767
it('handles invalid JS files', function (done) {
68-
var srcFile = new gutil.File({
68+
var srcFile = new File({
6969
path: path.join('test', 'fixtures', 'lib', 'add.js'),
7070
cwd: 'test/',
7171
base: 'test/fixtures/lib',
@@ -84,7 +84,7 @@ describe('gulp-istanbul', function () {
8484
var sourceMapStream = initStream.pipe(this.stream);
8585
sourceMapStream.on('data', function (file) {
8686
assert(file.sourceMap !== undefined);
87-
assert.equal(file.sourceMap.file, file.path);
87+
assert.equal(file.sourceMap.file, file.path.replace(/\\/g, '/'));
8888
done();
8989
});
9090

0 commit comments

Comments
 (0)