-
Notifications
You must be signed in to change notification settings - Fork 35
Open
Description
Hi @VinceFINET,
Hope you're still open to integrating Flow-Scanner (LFS) into OrgCheck—understand it's not a priority.
We can expose LFS as a separate static resource JS similar to how its used in Inspector Reloaded (maybe later replace with 2GP) for easy integration. I have prepared a draft PR to illustrate, however, I'd like to learn about OrgCheck's scoring; some logic overlaps with LFS (e.g., hard-coded IDs).
Overlapping issues:
- In the Automation page, under Flows, can you look at "DML in loops" and add a red flag in this case? #85
- Evaluation criteria - Workflows / Process builders #30
- Inconsistency between ItsDescription and FlowDescription on datatable in Flow tab page #607
- More of a question/clarification than an issue - Flow - Not referenced anywhere #598
The Pull Request:
-
5 unique LFS rules replace OrgCheck Rules
- InactiveFlow (100) → replaces Rule 35
- ProcessBuilder (101) → replaces Rule 37
- FlowDescription (102) → replaces Rules 38 + 53
- APIVersion (103) → replaces Rules 4 + 39
- UnsafeRunningContext (104) → replaces Rule 40
-
21 brand new checks (IDs 105-125)
- Performance: 105-107 (SOQL/DML/Actions in loops)
- Security: 108-109 (Hardcoded IDs/URLs)
- Reliability: 110-113 (Null handlers, fault paths, recursion, duplicates)
- Code Quality: 114-115, 120-121, 123-124 (8 rules)
- Maintainability: 116-119, 122, 125 (6 rules)
Direct benefits for OrgCheck:
- ✅ Reduces maintenance of 5 rule implementations
- ✅ Gain 20+ additional flow quality checks
- ✅ Still keeps OrgCheck's unique dependency analysis
Thanks!
Metadata
Metadata
Assignees
Labels
No labels