[Security] use secure PRNG for random array selection#7879
[Security] use secure PRNG for random array selection#7879gonzaloriestra wants to merge 2 commits into
Conversation
Replace Math.random() with globalThis.crypto.getRandomValues() in takeRandomFromArray to ensure cryptographically secure random selection.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
github-actions
Bot
added
the
no-changelog
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…tion Replace Math.random() with globalThis.crypto.getRandomValues() in takeRandomFromArray to ensure cryptographically secure random selection. Implemented rejection sampling to eliminate modulo bias.
2 participants
Summary
This PR hardens the
takeRandomFromArrayutility in@shopify/cli-kitby replacing the non-cryptographically secureMath.random()withglobalThis.crypto.getRandomValues().Why is this required?
Using a cryptographically secure PRNG ensures that random selections from an array are non-predictable, which is a standard security best practice even for non-sensitive use cases like generating random names.
How to test your changes?
CI
PR created automatically by Jules for task 14379531815097411834 started by @gonzaloriestra