Safe and unique saved attachment filename

Vitexus · Vitexus · commit bc397a46e0b3 · 2024-04-18T12:44:19.000+02:00
diff --git a/src/AbraFlexi/RO.php b/src/AbraFlexi/RO.php
@@ -2578,7 +2578,7 @@ public function downloadInFormat(
             $lang = null,
             $sign = false
     ) {
-        $downloadTo = $destDir . $this->getEvidence() . '_' . $this->getMyKey() . '.' . $format;
+        $downloadTo = $destDir . $this->getEvidence() . '_' . str_replace(['/',' ',':'],'_',$this->getRecordIdent()) . '.' . $format;
         $downloaded = $this->getInFormat($format, $reportName, $lang, $sign);
         return file_put_contents($downloadTo, $downloaded) ? $downloadTo : null;
     }

Original file line number	Diff line number	Diff line change
`@@ -2578,7 +2578,7 @@ public function downloadInFormat(`
`2578`	`2578`	`$lang = null,`
`2579`	`2579`	`$sign = false`
`2580`	`2580`	`) {`
`2581`		`- $downloadTo = $destDir . $this->getEvidence() . '_' . $this->getMyKey() . '.' . $format;`
	`2581`	`+ $downloadTo = $destDir . $this->getEvidence() . '_' . str_replace(['/',' ',':'],'_',$this->getRecordIdent()) . '.' . $format;`
`2582`	`2582`	`$downloaded = $this->getInFormat($format, $reportName, $lang, $sign);`
`2583`	`2583`	`return file_put_contents($downloadTo, $downloaded) ? $downloadTo : null;`
`2584`	`2584`	`}`