Server Side Rendered HTML Response should return HTTP 200 when loader rejects

[valerii15298]

Which project does this relate to?

Start

Describe the bug

When loader rejects the server side rendered response returns HTTP 500 even though the HTML was successfully rendered.

I would expect it to be 200 because html was successfully server side rendered and returned.
http 500 is more for server failure and rejections of loaders are expected, it is not internal server error.

Your Example Website or App

https://github.com/valerii15298/tss-repros/tree/error-component-override

Steps to Reproduce the Bug or Issue

Start the app
Open Browser network devtools
Go to http://localhost:3000
See that response for html content returns 500

Expected behavior

Should return 200

Screenshots or Videos

https://discord.com/channels/719702312431386674/1477778007018963014/1477791443463573748

Platform

• Router / Start Version: 1.165.0

[valerii15298]

Workaround

This seems to work:
start.ts file:

import { createMiddleware, createStart } from "@tanstack/react-start";

export const fixResponseHtmlStatus = createMiddleware().server(
  async ({ next }) => {
    const resp = await next();
    if (
      resp.response.status === 500 &&
      resp.response.headers.get("content-type") === "text/html; charset=utf-8"
    ) {
      resp.response = new Response(resp.response.body, {
        headers: resp.response.headers,
        status: 200,
      });
    }
    return resp;
  },
);

export const startInstance = createStart(() => ({
  requestMiddleware: [fixResponseHtmlStatus],
}));

Not sure if it is best approach, maybe there is a better way...