quality-debt: inc/class-addon-repository.php — PR #1601 review feedback (high)

[superdav42]

Unactioned Review Feedback

Source PR: #1601
File: inc/class-addon-repository.php
Reviewers: coderabbit
Findings: 1
Max severity: high

---

HIGH: coderabbit (coderabbitai[bot])

File: inc/class-addon-repository.php:59
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Keep the length comparison in Yoda form.

Line 59 introduces a non-Yoda comparison in production code.

Proposed fix

-		if (false === $iv_length || strlen($data) <= $iv_length) {
+		if (false === $iv_length || $iv_length >= strlen($data)) {

As per coding guidelines, "inc/**/*.php: Yoda conditions are required in production code."

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

		if (false === $iv_length || $iv_length >= strlen($data)) {

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@inc/class-addon-repository.php` at line 59, The conditional in the Addon
repository code has a non-Yoda length comparison, which violates the production
PHP coding guideline. Update the length check in the relevant branch of the
class-addon-repository logic so the comparison stays in Yoda form, matching the
existing style used alongside the iv_length validation and preserving the same
behavior.

Source: Coding guidelines

View comment

---

---

Auto-generated by quality-feedback-helper.sh scan-merged. Review each finding and either fix the code or dismiss with a reason.

---

aidevops.sh v3.31.19 automated scan.

[superdav42]

Superseded. Pre-dispatch review-feedback validator found merged PR #1603 in the source PR #1601 merge window after 2026-07-01T22:51:42Z. The PR touches the cited file path(s) and matches the finding signal, so worker dispatch is skipped.

• Source PR: fix: recover addon store oauth client id #1601
• Merged PR: fix: address addon repository review followup #1603
• Merged at: 2026-07-02T09:21:26Z
• Overlapping files: inc/class-addon-repository.php
• Matched signal: addon behavior class coderabbit comment comparison data existing false form

Closed automatically by the review-feedback supersession validator (t3569, GH#23101). If the finding recurs, a new review-feedback issue will be created by the next scan.

---

aidevops.sh v3.31.19 Overall, 2m since this issue was created.