Rework DefaultGraphConverter #42
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SoccerGraphConverterand renameSoccerGraphConverterPolarstoSoccerGraphConverterdefault_player.pyanddefault_frame.pythat were only used by the oldSoccerGraphConverterto_spektral_graphs,to_pickle,_verify_feature_funcs,return_dtypesandto_graph_framesto theDefaultGraphConverterso bothAmericanFootballGraphConverterandSoccerGraphConvertercan inherit straight from there.Columnobjects in the NFL dataset more closely to soccer such that we can ultimately (not yet done) move all functionality toDefaultGraphConverter. This means for exampleframeIdandgameIdare renamed toframe_idandgame_id.