Drop frame on encode error

bangnoise · bangnoise · commit e0ee38542fc4 · 2015-09-14T00:38:19.000+01:00
diff --git a/source/HapCompressor.c b/source/HapCompressor.c
@@ -912,7 +912,8 @@ Hap_CEncodeFrame(
     }
 
     HapCodecTasksAddTask(glob->taskGroup, buffer);
-    
+    sourceFrame = NULL; // indicate to bail: that we don't need to drop it
+
     // Dequeue and deliver any encoded frames
     do
     {
@@ -930,6 +931,8 @@ Hap_CEncodeFrame(
     {
         ICMEncodedFrameRelease(encodedFrame);
     }
+    if (sourceFrame)
+        ICMCompressorSessionDropFrame(glob->session, sourceFrame);
     debug_print_err(glob, err);
 	return err;
 }

Original file line number	Diff line number	Diff line change
`@@ -912,7 +912,8 @@ Hap_CEncodeFrame(`
`912`	`912`	`}`
`913`	`913`
`914`	`914`	`HapCodecTasksAddTask(glob->taskGroup, buffer);`
`915`		`-`
	`915`	`+ sourceFrame = NULL; // indicate to bail: that we don't need to drop it`
	`916`	`+`
`916`	`917`	`// Dequeue and deliver any encoded frames`
`917`	`918`	`do`
`918`	`919`	`{`
`@@ -930,6 +931,8 @@ Hap_CEncodeFrame(`
`930`	`931`	`{`
`931`	`932`	`ICMEncodedFrameRelease(encodedFrame);`
`932`	`933`	`}`
	`934`	`+ if (sourceFrame)`
	`935`	`+ ICMCompressorSessionDropFrame(glob->session, sourceFrame);`
`933`	`936`	`debug_print_err(glob, err);`
`934`	`937`	`return err;`
`935`	`938`	`}`