Skip to content

Commit 5570518

Browse files
authored
spec: Rename embedderParent to controlledFrameEmbedderParent (#145)
1 parent 5d810bd commit 5570518

File tree

1 file changed

+65
-67
lines changed

1 file changed

+65
-67
lines changed

index.bs

Lines changed: 65 additions & 67 deletions
Original file line numberDiff line numberDiff line change
@@ -392,7 +392,7 @@ the respective content attributes of the same name.
392392

393393
Each <{controlledframe}> has an associated:
394394
* <dfn for=controlledframe>embedded navigable</dfn>, a
395-
[=traversable navigable=] with a non-null [=embedderParent=], or null.
395+
[=traversable navigable=] with a non-null [=controlledFrameEmbedderParent=], or null.
396396
It is initially null.
397397

398398
Note: The [=embedded navigable=] appears as a top-level traversable with a
@@ -458,7 +458,7 @@ steps are to return [=this=]'s [=controlledframe/contextMenus=].
458458

459459
1. [=Initialize the navigable=] |traversable| given |documentState|.
460460

461-
1. Set |traversable|'s [=embedderParent=] to |element|.
461+
1. Set |traversable|'s [=controlledFrameEmbedderParent=] to |element|.
462462

463463
1. Set |element|'s [=embedded navigable=] to |traversable|.
464464

@@ -1123,10 +1123,10 @@ A <dfn>content script config</dfn> is a [=struct=] with the following
11231123
1. Let |embeddedNavigable| be |document|'s [=node navigable=]'s
11241124
[=traversable navigable=].
11251125

1126-
1. If |embeddedNavigable| is null or its [=embedderParent=] is null, then
1126+
1. If |embeddedNavigable| is null or its [=controlledFrameEmbedderParent=] is null, then
11271127
return.
11281128

1129-
1. Let |controlledframe| be |embeddedNavigable|'s [=embedderParent=].
1129+
1. Let |controlledframe| be |embeddedNavigable|'s [=controlledFrameEmbedderParent=].
11301130

11311131
1. Let |url| be |document|'s [=Document/URL=].
11321132

@@ -1207,7 +1207,7 @@ implementation of this isolation that can be implemented by all browsers.
12071207
given |script|.
12081208

12091209
1. Let |controlledframe| be |document|'s [=node navigable=]'s
1210-
[=traversable navigable=]'s [=embedderParent=].
1210+
[=traversable navigable=]'s [=controlledFrameEmbedderParent=].
12111211

12121212
1. [=Queue a global task=] on the [=DOM manipulation task source=] of
12131213
|controlledframe|'s [=relevant global object=] that will run
@@ -1738,7 +1738,7 @@ The <dfn method for=HTMLControlledFrameElement>setZoom(|zoomFactor|)</dfn> metho
17381738
[=active document=].
17391739

17401740
1. Let |embedder| be |embeddedDocument|'s [=node navigable=]'s
1741-
[=embedderParent=].
1741+
[=controlledFrameEmbedderParent=].
17421742

17431743
1. If |embedder| is null, then [=continue=].
17441744

@@ -2731,34 +2731,34 @@ For [=alert=]:
27312731

27322732
4. Set |message| to the result of optionally truncating message.
27332733

2734-
5. <ins>Let |embedderParent| be <var ignore=''>window</var>'s
2735-
[=Window/navigable=]'s [=embedderParent=].</ins>.
2734+
5. <ins>Let |controlledFrameEmbedderParent| be <var ignore=''>window</var>'s
2735+
[=Window/navigable=]'s [=controlledFrameEmbedderParent=].</ins>.
27362736

2737-
6. <ins>If |embedderParent| is a {{HTMLControlledFrameElement}}, then
2738-
[=fire a "dialog" event=] with |embedderParent|, "alert" and |message|,
2737+
6. <ins>If |controlledFrameEmbedderParent| is a {{HTMLControlledFrameElement}}, then
2738+
[=fire a "dialog" event=] with |controlledFrameEmbedderParent|, "alert" and |message|,
27392739
and return.</ins>
27402740

27412741
For [=confirm=]:
27422742

27432743
3. Set |message| to the result of optionally truncating message.
27442744

2745-
4. <ins>Let |embedderParent| be <var ignore=''>window</var>'s
2746-
[=Window/navigable=]'s [=embedderParent=].</ins>.
2745+
4. <ins>Let |controlledFrameEmbedderParent| be <var ignore=''>window</var>'s
2746+
[=Window/navigable=]'s [=controlledFrameEmbedderParent=].</ins>.
27472747

2748-
5. <ins>If |embedderParent| is a {{HTMLControlledFrameElement}}, then return
2749-
the result of [=firing a "dialog" event=] with |embedderParent|, "confirm",
2748+
5. <ins>If |controlledFrameEmbedderParent| is a {{HTMLControlledFrameElement}}, then return
2749+
the result of [=firing a "dialog" event=] with |controlledFrameEmbedderParent|, "confirm",
27502750
and |message|.</ins>
27512751

27522752
For [=prompt=]:
27532753

27542754
4. Set <var ignore=''>default</var> to the result of optionally truncating default.
27552755

2756-
5. <ins>Let |embedderParent| be <var ignore=''>window</var>'s [=Window/navigable=]'s [=embedderParent=].</ins>.
2756+
5. <ins>Let |controlledFrameEmbedderParent| be <var ignore=''>window</var>'s [=Window/navigable=]'s [=controlledFrameEmbedderParent=].</ins>.
27572757

2758-
6. <ins>If |embedderParent| is a {{HTMLControlledFrameElement}}, then:</ins>
2758+
6. <ins>If |controlledFrameEmbedderParent| is a {{HTMLControlledFrameElement}}, then:</ins>
27592759

27602760
1. <ins>Let |accept| and |response| be the results of [=firing a "dialog"
2761-
event=] with |embedderParent|, "prompt" and |message|.</ins>
2761+
event=] with |controlledFrameEmbedderParent|, "prompt" and |message|.</ins>
27622762

27632763
1. <ins>If |accept| equals `false`, return null.</ins>
27642764

@@ -2768,18 +2768,18 @@ For [=window open steps=]:
27682768

27692769
1. <ins>Let |windowOpenDisposition| be "{{WindowOpenDisposition/ignore}}".</ins>
27702770

2771-
2. <ins>Let |embedderParent| be <var ignore=''>sourceDocument</var>'s [=node
2772-
navigable=]'s [=embedderParent=].</ins>
2771+
2. <ins>Let |controlledFrameEmbedderParent| be <var ignore=''>sourceDocument</var>'s [=node
2772+
navigable=]'s [=controlledFrameEmbedderParent=].</ins>
27732773

27742774
...
27752775

27762776
<del>14. If |targetNavigable| is null, then return null.</del>
27772777

27782778
14. <ins>If |targetNavigable| is null:</ins>
27792779

2780-
1. <ins>If |embedderParent| is not null:</ins>
2780+
1. <ins>If |controlledFrameEmbedderParent| is not null:</ins>
27812781

2782-
1. <ins>[=Fire a "newwindow" event=] with |embedderParent|, |url|,
2782+
1. <ins>[=Fire a "newwindow" event=] with |controlledFrameEmbedderParent|, |url|,
27832783
|target|, |targetNavigable|, and |windowOpenDisposition|.</ins>
27842784

27852785
1. <ins>Return null.<ins>
@@ -2819,21 +2819,19 @@ Note: Step 15 and 16 also [=/navigate=] |targetNavigable|; during navigation,
28192819
download, then |windowOpenDisposition| may be set to
28202820
"{{WindowOpenDisposition/save_to_disk}}".
28212821

2822-
1. <ins>If |embedderParent| is not null:</ins>
2822+
1. <ins>If |controlledFrameEmbedderParent| is not null:</ins>
28232823

2824-
1. <ins>[=Fire a "newwindow" event=] with |embedderParent|, |url|,
2824+
1. <ins>[=Fire a "newwindow" event=] with |controlledFrameEmbedderParent|, |url|,
28252825
|target|, |targetNavigable|, and |windowOpenDisposition|.</ins>
28262826

28272827

2828-
2829-
28302828
For [=completely finish loading=]:
28312829

28322830
5. Otherwise, if container is non-null, then queue an element task on the DOM manipulation task source given container to fire an event named load at container.
28332831

2834-
6. <ins>Let |embedderParent| be <var ignore=''>document</var>'s [=node navigable=]'s [=embedderParent=].
2832+
6. <ins>Let |controlledFrameEmbedderParent| be <var ignore=''>document</var>'s [=node navigable=]'s [=controlledFrameEmbedderParent=].
28352833

2836-
7. <ins> If |embedderParent| is {{HTMLControlledFrameElement}}, then [=Fire a "contentload" event=] with |embedderParent|.</ins>
2834+
7. <ins> If |controlledFrameEmbedderParent| is {{HTMLControlledFrameElement}}, then [=Fire a "contentload" event=] with |controlledFrameEmbedderParent|.</ins>
28372835

28382836
<div style="border: 2px solid red;">
28392837

@@ -2845,7 +2843,7 @@ Monkey-patch for loadstart, loadabort, and loadcommit which looks like the follo
28452843

28462844
1. loadabort -> at each early exist points of the algorithm between loadstart and loadcommit.
28472845

2848-
For each of these, check whether the [=top-level traversable=] of the [=/navigable=] has an [=embedderParent=] of {{HTMLControlledFrameElement}}, if so, then fire the corresponding event with input arguments.
2846+
For each of these, check whether the [=top-level traversable=] of the [=/navigable=] has an [=controlledFrameEmbedderParent=] of {{HTMLControlledFrameElement}}, if so, then fire the corresponding event with input arguments.
28492847

28502848
</div>
28512849

@@ -2859,17 +2857,17 @@ For [=HTTP fetch=](loadredirect):
28592857

28602858
1. <ins>Let |currentNavigable| be |window|'s associated [=Window/navigable=].
28612859

2862-
1. <ins>Let |embedderParent| be |currentNavigable|'s [=top-level traversable=]'s [=embedderParent=].</ins>
2860+
1. <ins>Let |controlledFrameEmbedderParent| be |currentNavigable|'s [=top-level traversable=]'s [=controlledFrameEmbedderParent=].</ins>
28632861

2864-
1. <ins>If |embedderParent| is a {{HTMLControlledFrameElement}}:</ins>
2862+
1. <ins>If |controlledFrameEmbedderParent| is a {{HTMLControlledFrameElement}}:</ins>
28652863

28662864
1.<ins>Let |oldUrl| be |request|'s associated [=request/URL=].</ins>
28672865

28682866
1.<ins>Let |newUrl| be |response|'s [=response/location url=].</ins>
28692867

28702868
1.<ins>Let |isTopLevel| be `false`, if |currentNavigable| has a null [=navigable/parent=] set |isTopLevel| to `true`.
28712869

2872-
1.<ins>[=Fire a "loadredirect" event=] with |embedderParent|, |oldUrl|, |newUrl|, and |isTopLevel|.</ins>
2870+
1.<ins>[=Fire a "loadredirect" event=] with |controlledFrameEmbedderParent|, |oldUrl|, |newUrl|, and |isTopLevel|.</ins>
28732871

28742872
#### [[Permissions]] #### {#events-monkey-patches-permissions}
28752873

@@ -2883,12 +2881,12 @@ permission</dfn> given DOMString |permission|, an optional dictionary
28832881
|options|, and an algorithm |completionSteps| that takes a [=boolean=],
28842882
run the following steps:
28852883

2886-
1. Let |embedderParent| be |document|'s [=node navigable=]'s [=embedderParent=].
2884+
1. Let |controlledFrameEmbedderParent| be |document|'s [=node navigable=]'s [=controlledFrameEmbedderParent=].
28872885

2888-
1. If |embedderParent| is not {{HTMLControlledFrameElement}}, return `true`.
2886+
1. If |controlledFrameEmbedderParent| is not {{HTMLControlledFrameElement}}, return `true`.
28892887

28902888
1. [=Fire a "permissionrequest" event=] with |document|,
2891-
|embedderParent|, |permission|, |document|'s [=Document/URL=], |options|, and
2889+
|controlledFrameEmbedderParent|, |permission|, |document|'s [=Document/URL=], |options|, and
28922890
|completionSteps|.
28932891

28942892
</div>
@@ -2917,11 +2915,11 @@ For [=request a position=] (geolocation):
29172915

29182916
1. <ins>Terminate this algorithm.</ins>
29192917

2920-
7. <ins>Let |embedderParent| be |document|'s [=node navigable=]'s [=embedderParent=].</ins>
2918+
7. <ins>Let |controlledFrameEmbedderParent| be |document|'s [=node navigable=]'s [=controlledFrameEmbedderParent=].</ins>
29212919

2922-
8. <ins>If |embedderParent| is {{HTMLControlledFrameElement}}:</ins>
2920+
8. <ins>If |controlledFrameEmbedderParent| is {{HTMLControlledFrameElement}}:</ins>
29232921

2924-
1. Let |nodeDocument| be |embedderParent|'s [=node document=].
2922+
1. Let |nodeDocument| be |controlledFrameEmbedderParent|'s [=node document=].
29252923

29262924
1. <ins>If |nodeDocument| is null:</ins>
29272925

@@ -2966,8 +2964,8 @@ the needs of Controlled Frame.
29662964
Each [=/navigable=] has:
29672965
* A <dfn for=navigable>frameId</dfn> integer, initially 0.
29682966
* A <dfn for=navigable>next frameId</dfn> integer, initially 1.
2969-
* An <dfn for=navigable>embedderParent</dfn>, an {{HTMLControlledFrameElement}}
2970-
or null.
2967+
* An <dfn for=navigable>controlledFrameEmbedderParent</dfn>, an
2968+
{{HTMLControlledFrameElement}} or null.
29712969

29722970
The [=initialize the navigable=] algorithm given a [=/navigable=] |navigable|
29732971
and an optional [=/navigable=]-or-null |parent| (default null) is
@@ -3018,12 +3016,12 @@ To determine the network partition key, given an [=environment=] |environment|:
30183016

30193017
5. Let |secondKey| be null <del>or an [=implementation-defined=] value</del>.
30203018

3021-
6. <ins>Let |embedderParent| be the result of [=getting an environment's
3022-
embedderParent=] given |environment|.</ins>
3019+
6. <ins>Let |controlledFrameEmbedderParent| be the result of [=getting an environment's
3020+
controlledFrameEmbedderParent=] given |environment|.</ins>
30233021

3024-
7. <ins>If |embedderParent| is not null, then set |secondKey| to a [=tuple=]
3025-
consisting of the [=environment/top-level origin=] of |embedderParent|'s
3026-
[=relevant settings object=], and |embedderParent|'s
3022+
7. <ins>If |controlledFrameEmbedderParent| is not null, then set |secondKey| to a [=tuple=]
3023+
consisting of the [=environment/top-level origin=] of |controlledFrameEmbedderParent|'s
3024+
[=relevant settings object=], and |controlledFrameEmbedderParent|'s
30273025
{{HTMLControlledFrameElement/partition}}.</ins>
30283026

30293027
8. Return (|topLevelSite|, |secondKey|).
@@ -3062,15 +3060,15 @@ To <dfn data-lt='obtain a Controlled Frame storage key'>obtain a storage key for
30623060

30633061
1. <ins>Let |topLevelOrigin| and |partition| be null.</ins>
30643062

3065-
1. <ins>Let |embedderParent| be the result of [=getting an environment's
3066-
embedderParent=] given |environment|.</ins>
3063+
1. <ins>Let |controlledFrameEmbedderParent| be the result of [=getting an environment's
3064+
controlledFrameEmbedderParent=] given |environment|.</ins>
30673065

3068-
1. <ins>If |embedderParent| is not null, then:</ins>
3066+
1. <ins>If |controlledFrameEmbedderParent| is not null, then:</ins>
30693067

30703068
1. <ins>Set |topLevelOrigin| to the [=environment/top-level origin=] of
3071-
|embedderParent|'s [=relevant settings object=].</ins>
3069+
|controlledFrameEmbedderParent|'s [=relevant settings object=].</ins>
30723070

3073-
1. <ins>Set |partition| to |embedderParent|'s
3071+
1. <ins>Set |partition| to |controlledFrameEmbedderParent|'s
30743072
{{HTMLControlledFrameElement/partition}}.</ins>
30753073

30763074
1. <ins>Return a [=tuple=] consisting of |topLevelOrigin|, |partition|,
@@ -3079,24 +3077,24 @@ To <dfn data-lt='obtain a Controlled Frame storage key'>obtain a storage key for
30793077
</div>
30803078

30813079
<div algorithm>
3082-
To <dfn>get an [=environment=]'s [=embedderParent=]</dfn> given an
3083-
[=environment=] |environment|, run the following steps:
3080+
To <dfn>get an [=environment=]'s [=controlledFrameEmbedderParent=]</dfn> given
3081+
an [=environment=] |environment|, run the following steps:
30843082

30853083
1. If |environment| is an [=environment settings object=] whose
30863084
[=global object=] is a {{Window}} object, then:
30873085

30883086
Issue: This algorithm doesn't work for Shared or Service Workers because
3089-
[=embedderParent=] is only defined on a [=/navigable=], and it's not
3090-
always possible to go from a non-{{Window}} [=environment=] to a
3087+
[=controlledFrameEmbedderParent=] is only defined on a [=/navigable=], and
3088+
it's not always possible to go from a non-{{Window}} [=environment=] to a
30913089
[=/navigable=].
30923090

30933091
1. Let |navigable| be |environment|'s [=global object=]'s
30943092
[=Window/navigable=].
30953093

30963094
1. Let |top| be the [=top-level traversable=] of |navigable|.
30973095

3098-
1. If |top|'s [=embedderParent=] is not null, then return |top|'s
3099-
[=embedderParent=].
3096+
1. If |top|'s [=controlledFrameEmbedderParent=] is not null, then return |top|'s
3097+
[=controlledFrameEmbedderParent=].
31003098

31013099
1. Return null.
31023100

@@ -3634,10 +3632,10 @@ Each {{WebRequestResponseStartedEvent}} has an associated:
36343632

36353633
1. Let |navigable| be |window|'s [=Window/navigable=].
36363634

3637-
1. If |navigable| or its [=embedderParent=] is null, return an empty [=list=]
3635+
1. If |navigable| or its [=controlledFrameEmbedderParent=] is null, return an empty [=list=]
36383636
and `false`.
36393637

3640-
1. Let |controlledFrame| be |navigable|'s [=embedderParent=].
3638+
1. Let |controlledFrame| be |navigable|'s [=controlledFrameEmbedderParent=].
36413639

36423640
1. Let |applicableInterceptors| be an empty [=list=].
36433641

@@ -3957,7 +3955,7 @@ A <dfn>WebRequestEvent result</dfn> is a [=struct=] with the following
39573955
1. Let |pendingHandlerCount| be 0.
39583956

39593957
1. Let |controlledFrameEmbedderGlobal| be the [=relevant global object=] of
3960-
the result of [=getting an environment's embedderParent=] given
3958+
the result of [=getting an environment's controlledFrameEmbedderParent=] given
39613959
|request|'s [=request/client=].
39623960

39633961
1. If |controlledFrameEmbedderGlobal| is null, then return.
@@ -4060,7 +4058,7 @@ A <dfn>WebRequestEvent result</dfn> is a [=struct=] with the following
40604058
1. Let |pendingHandlerCount| be 0.
40614059

40624060
1. Let |controlledFrameEmbedderGlobal| be the [=relevant global object=] of
4063-
the result of [=getting an environment's embedderParent=] given
4061+
the result of [=getting an environment's controlledFrameEmbedderParent=] given
40644062
|request|'s [=request/client=].
40654063

40664064
1. If |controlledFrameEmbedderGlobal| is null, then return.
@@ -4119,7 +4117,7 @@ A <dfn>WebRequestEvent result</dfn> is a [=struct=] with the following
41194117
[=applicable WebRequestInterceptors=] of |request|.
41204118

41214119
1. Let |controlledFrameEmbedderGlobal| be the [=relevant global object=] of
4122-
the result of [=getting an environment's embedderParent=] given
4120+
the result of [=getting an environment's controlledFrameEmbedderParent=] given
41234121
|request|'s [=request/client=].
41244122

41254123
1. If |controlledFrameEmbedderGlobal| is null, then return.
@@ -4151,7 +4149,7 @@ A <dfn>WebRequestEvent result</dfn> is a [=struct=] with the following
41514149
1. Let |pendingHandlerCount| be |interceptor|'s [=list/size=].
41524150

41534151
1. Let |controlledFrameEmbedderGlobal| be the [=relevant global object=] of
4154-
the result of [=getting an environment's embedderParent=] given
4152+
the result of [=getting an environment's controlledFrameEmbedderParent=] given
41554153
|request|'s [=request/client=].
41564154

41574155
1. If |controlledFrameEmbedderGlobal| is null, then return.
@@ -4252,7 +4250,7 @@ A <dfn>WebRequestEvent result</dfn> is a [=struct=] with the following
42524250
1. Let |pendingHandlerCount| be 0.
42534251

42544252
1. Let |controlledFrameEmbedderGlobal| be the [=relevant global object=] of
4255-
the result of [=getting an environment's embedderParent=] given
4253+
the result of [=getting an environment's controlledFrameEmbedderParent=] given
42564254
|request|'s [=request/client=].
42574255

42584256
1. If |controlledFrameEmbedderGlobal| is null, then return.
@@ -4352,7 +4350,7 @@ A <dfn>WebRequestEvent result</dfn> is a [=struct=] with the following
43524350
[=applicable WebRequestInterceptors=] of |request|.
43534351

43544352
1. Let |controlledFrameEmbedderGlobal| be the [=relevant global object=] of
4355-
the result of [=getting an environment's embedderParent=] given
4353+
the result of [=getting an environment's controlledFrameEmbedderParent=] given
43564354
|request|'s [=request/client=].
43574355

43584356
1. If |controlledFrameEmbedderGlobal| is null, then return.
@@ -4393,7 +4391,7 @@ A <dfn>WebRequestEvent result</dfn> is a [=struct=] with the following
43934391
[=applicable WebRequestInterceptors=] of |request|.
43944392

43954393
1. Let |controlledFrameEmbedderGlobal| be the [=relevant global object=] of
4396-
the result of [=getting an environment's embedderParent=] given
4394+
the result of [=getting an environment's controlledFrameEmbedderParent=] given
43974395
|request|'s [=request/client=].
43984396

43994397
1. If |controlledFrameEmbedderGlobal| is null, then return.
@@ -4426,7 +4424,7 @@ A <dfn>WebRequestEvent result</dfn> is a [=struct=] with the following
44264424
[=applicable WebRequestInterceptors=] of |request|.
44274425

44284426
1. Let |controlledFrameEmbedderGlobal| be the [=relevant global object=] of
4429-
the result of [=getting an environment's embedderParent=] given
4427+
the result of [=getting an environment's controlledFrameEmbedderParent=] given
44304428
|request|'s [=request/client=].
44314429

44324430
1. If |controlledFrameEmbedderGlobal| is null, then return.
@@ -4459,7 +4457,7 @@ A <dfn>WebRequestEvent result</dfn> is a [=struct=] with the following
44594457
[=applicable WebRequestInterceptors=] of |request|.
44604458

44614459
1. Let |controlledFrameEmbedderGlobal| be the [=relevant global object=] of
4462-
the result of [=getting an environment's embedderParent=] given
4460+
the result of [=getting an environment's controlledFrameEmbedderParent=] given
44634461
|request|'s [=request/client=].
44644462

44654463
1. If |controlledFrameEmbedderGlobal| is null, then return.
@@ -5169,7 +5167,7 @@ of the items.
51695167
[=context menu/context element=].
51705168

51715169
1. Let |controlledframe| be |element|'s [=node navigable=]'s
5172-
[=embedderParent=].
5170+
[=controlledFrameEmbedderParent=].
51735171

51745172
1. If |controlledframe| is null, then return `false`.
51755173

0 commit comments

Comments
 (0)