Fix Unsubtyping on extern.convert_any #8062
Merged
+95
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were not previously recording that the input to extern.convert_any has to be a subtype of anyref. This meant that it was possible for Unsubtyping to optimize too aggressively and break casts.
Merged
kripken
approved these changes
Nov 19, 2025
| case RefAsNonNull: | ||
| self()->noteCast(curr->value, curr); | ||
| return; | ||
| case AnyConvertExtern: |
Member
Author
There was a problem hiding this comment.
In principle, yes, but extern has no defined subtypes, so in practice (for Unsubtyping, at least) it doesn't matter.
Member
There was a problem hiding this comment.
Right, I guess it doesn't make a difference...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not previously recording that the input to extern.convert_any
has to be a subtype of anyref. This meant that it was possible for
Unsubtyping to optimize too aggressively and break casts.