Skip to content

Commit 84fbeaf

Browse files
Merge pull request #8 from laravel-shift/l11-compatibility
Laravel 11.x Compatibility
2 parents 5548502 + 06d9e28 commit 84fbeaf

File tree

3 files changed

+21
-20
lines changed

3 files changed

+21
-20
lines changed

.github/workflows/tests.yml

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -4,42 +4,43 @@ on:
44
push:
55
branches:
66
- main
7-
87
pull_request:
9-
types: [ opened, synchronize, reopened ]
8+
types:
9+
- opened
10+
- synchronize
11+
- reopened
1012

1113
jobs:
1214
test:
1315
runs-on: ubuntu-latest
16+
1417
strategy:
1518
fail-fast: false
1619
matrix:
17-
php: [ 8.0, 8.1, 8.2 ]
18-
laravel: [ 8.*, 9.*, 10.* ]
19-
dependency-version: [ prefer-lowest, prefer-stable ]
20+
php: [8.0, 8.1, 8.2]
21+
laravel: ['8.*', '9.*', '10.*', '11.*']
22+
dependency-version: [prefer-lowest, prefer-stable]
2023
include:
2124
- laravel: 8.*
2225
testbench: 6.*
23-
2426
- laravel: 9.*
2527
testbench: 7.*
26-
2728
- laravel: 10.*
2829
testbench: 8.*
29-
30+
- laravel: 11.*
31+
testbench: 9.*
3032
exclude:
31-
# Laravel 8 lowest isn't compatible with newer PHP versions
3233
- laravel: 8.*
3334
dependency-version: prefer-lowest
34-
35-
# PHP 8.2 requires Laravel 9.33 at least, so skip lowest
3635
- laravel: 9.*
3736
php: 8.2
3837
dependency-version: prefer-lowest
39-
40-
# Laravel 10 requires PHP 8.1
4138
- laravel: 10.*
4239
php: 8.0
40+
- laravel: 11.*
41+
php: 8.0
42+
- laravel: 11.*
43+
php: 8.1
4344

4445
name: P${{ matrix.php }} / L${{ matrix.laravel }} / ${{ matrix.dependency-version }}
4546

composer.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,14 @@
1111
],
1212
"require": {
1313
"php": "^8.0",
14-
"illuminate/support": "^8.0|^9.0|^10",
15-
"illuminate/cache": "^8.0|^9.0|^10",
16-
"illuminate/console": "^8.0|^9.0|^10"
14+
"illuminate/support": "^8.0|^9.0|^10|^11.0",
15+
"illuminate/cache": "^8.0|^9.0|^10|^11.0",
16+
"illuminate/console": "^8.0|^9.0|^10|^11.0"
1717
},
1818
"require-dev": {
1919
"mockery/mockery": "^1.3.3",
2020
"phpunit/phpunit": ">=8.5.23|^9",
21-
"orchestra/testbench": "^6.0|^7.0|^8.0"
21+
"orchestra/testbench": "^6.0|^7.0|^8.0|^9.0"
2222
},
2323
"autoload": {
2424
"psr-4": {

src/Flaky.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ public function run(callable $callable)
6464
return new Result($value, $exception);
6565
}
6666

67-
public function handle(Throwable $exception = null)
67+
public function handle(?Throwable $exception = null)
6868
{
6969
return $this->run(function () use ($exception) {
7070
if (!is_null($exception)) {
@@ -215,7 +215,7 @@ protected function normalizeRetryWhen($when = null)
215215
return $when;
216216
}
217217

218-
protected function shouldThrowImmediately(Throwable $exception = null)
218+
protected function shouldThrowImmediately(?Throwable $exception = null)
219219
{
220220
if (is_null($exception)) {
221221
return false;
@@ -224,7 +224,7 @@ protected function shouldThrowImmediately(Throwable $exception = null)
224224
return $this->protectionsBypassed() || !$this->exceptionIsFlaky($exception);
225225
}
226226

227-
protected function exceptionIsFlaky(Throwable $exception = null)
227+
protected function exceptionIsFlaky(?Throwable $exception = null)
228228
{
229229
return is_null($this->flakyExceptions) || in_array(get_class($exception), $this->flakyExceptions, true);
230230
}

0 commit comments

Comments
 (0)