Skip to content

Commit 9af5a99

Browse files
committed
Make SSG provider methods static if they can be
1 parent 904065c commit 9af5a99

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

sqlsynthgen/providers.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,9 @@ class Meta:
1717

1818
name = "column_value_provider"
1919

20+
@staticmethod
2021
def column_value(
21-
self, db_connection: Connection, orm_class: Any, column_name: str
22+
db_connection: Connection, orm_class: Any, column_name: str
2223
) -> Any:
2324
"""Return a random value from the column specified."""
2425
query = select(orm_class).order_by(functions.random()).limit(1)
@@ -50,8 +51,8 @@ class Meta:
5051

5152
name = "timedelta_provider"
5253

54+
@staticmethod
5355
def timedelta(
54-
self,
5556
min_dt: dt.timedelta = dt.timedelta(seconds=0),
5657
# ints bigger than this cause trouble
5758
max_dt: dt.timedelta = dt.timedelta(seconds=2**32),
@@ -75,8 +76,8 @@ class Meta:
7576

7677
name = "timespan_provider"
7778

79+
@staticmethod
7880
def timespan(
79-
self,
8081
earliest_start_year: int,
8182
last_start_year: int,
8283
min_dt: dt.timedelta = dt.timedelta(seconds=0),
@@ -194,6 +195,7 @@ class Meta:
194195

195196
name = "null_provider"
196197

197-
def null(self) -> None:
198+
@staticmethod
199+
def null() -> None:
198200
"""Return `None`."""
199201
return None

0 commit comments

Comments
 (0)