Skip to content

spec(control-plane): define Kueue session admission#1675

Draft
jsell-rh wants to merge 6 commits into
mainfrom
jsell/spec/kueue
Draft

spec(control-plane): define Kueue session admission#1675
jsell-rh wants to merge 6 commits into
mainfrom
jsell/spec/kueue

Conversation

@jsell-rh

Copy link
Copy Markdown
Contributor

Summary

  • add a Kueue Session Admission spec with first-class Queued session phase semantics
  • define Project session_admission intent, profile catalog, Application sync boundaries, and control-plane plain-Pod admission behavior
  • update the Ambient model spec for Project, Session, Application, CLI/apply, and migration coverage

Verification

  • git diff --check origin/main...HEAD -- specs/api/ambient-model.spec.md specs/control-plane/kueue-session-admission.spec.md
  • agent critic pass: schema/migration, RBAC/auth, terminology, control-plane/Kueue, consumer migration; final targeted rechecks returned no blocker/major findings
  • pre-commit hook: Global rh-pre-commit passed during commit

Note: previous draft PR #1674 was closed because it used the wrong head branch.

@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 9746a6da-a335-4ed0-a8a6-563045d4742f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jsell/spec/kueue
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch jsell/spec/kueue

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@netlify

netlify Bot commented Jun 10, 2026

Copy link
Copy Markdown

Deploy Preview for cheerful-kitten-f556a0 canceled.

Name Link
🔨 Latest commit 9661b1d
🔍 Latest deploy log https://app.netlify.com/projects/cheerful-kitten-f556a0/deploys/6a299f5ff47f3000085824a0

1 similar comment
@netlify

netlify Bot commented Jun 10, 2026

Copy link
Copy Markdown

Deploy Preview for cheerful-kitten-f556a0 canceled.

Name Link
🔨 Latest commit 9661b1d
🔍 Latest deploy log https://app.netlify.com/projects/cheerful-kitten-f556a0/deploys/6a299f5ff47f3000085824a0

@jsell-rh jsell-rh requested a review from markturansky June 10, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant