branch-4.1: [feat](Variant) Support NestedGroup public config#64679
Open
eldenmoon wants to merge 1 commit into
Open
branch-4.1: [feat](Variant) Support NestedGroup public config#64679eldenmoon wants to merge 1 commit into
eldenmoon wants to merge 1 commit into
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.
Enables VARIANT NestedGroup support as a public configuration and wires build-time toggles for the NestedGroup feature module.
Changes:
- Adjusts FE parsing/serialization and tests to accept
variant_enable_nested_groupand validate conflicts with doc mode. - Adds BE build flags and CMake integration to optionally compile a NestedGroup module and its unit tests.
- Updates default NestedGroup-related config and strengthens default provider behavior to reject write path when not built.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| regression-test/suites/variant_p0/test_variant_search_subcolumn.groovy | Adds context comment tying the suite to Variant SEARCH subcolumn binding behavior. |
| fe/fe-core/src/test/java/org/apache/doris/nereids/parser/NereidsParserTest.java | Updates parser tests to accept NestedGroup property and assert conflict error with doc mode. |
| fe/fe-core/src/test/java/org/apache/doris/catalog/TypeTest.java | Updates VariantType SQL serialization test to require nested group property output. |
| fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java | Changes NestedGroup parsing behavior from “reject” to “override/disable other features”. |
| fe/fe-common/src/main/java/org/apache/doris/catalog/VariantType.java | Serializes variant_enable_nested_group into toSql(). |
| build.sh | Adds env-driven cmake options for enabling NestedGroup module and setting its directory. |
| be/test/storage/segment/nested_group_provider_test.cpp | Expands tests ensuring default provider rejects NestedGroup write path with correct status codes. |
| be/test/CMakeLists.txt | Conditionally includes NestedGroup module unit tests when feature is enabled. |
| be/src/storage/segment/variant/nested_group_provider.cpp | Changes default write provider from no-op OK to NotSupported. |
| be/src/storage/CMakeLists.txt | Conditionally replaces default provider with module sources when NestedGroup feature is enabled. |
| be/src/common/config.cpp | Changes default for variant_nested_group_discard_scalar_on_conflict to true. |
| be/CMakeLists.txt | Adds ENABLE_NESTED_GROUP option and requires module dir when enabled. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+5309
to
+5313
| enableVariantDocMode = false; | ||
| variantMaxSubcolumnsCount = 0; | ||
| enableTypedPathsToSparse = false; | ||
| variantMaxSparseColumnStatisticsSize = 0; | ||
| variantSparseHashShardCount = 0; |
Comment on lines
+190
to
+194
| if (enableNestedGroup) { | ||
| sb.append(","); | ||
| sb.append("\"variant_enable_nested_group\" = \"") | ||
| .append(String.valueOf(enableNestedGroup)).append("\""); | ||
| } |
Comment on lines
+26
to
+30
| if (ENABLE_NESTED_GROUP) | ||
| file(GLOB_RECURSE NESTED_GROUP_UT_FILES CONFIGURE_DEPENDS | ||
| "${CMAKE_CURRENT_SOURCE_DIR}/${NESTED_GROUP_MODULE_DIR}/*.cpp") | ||
| list(APPEND UT_FILES ${NESTED_GROUP_UT_FILES}) | ||
| endif() |
| // Deeper arrays will be stored as JSONB | ||
| DEFINE_mInt32(variant_nested_group_max_depth, "10"); | ||
| DEFINE_mBool(variant_nested_group_discard_scalar_on_conflict, "false"); | ||
| DEFINE_mBool(variant_nested_group_discard_scalar_on_conflict, "true"); |
Comment on lines
+713
to
+714
| -DENABLE_NESTED_GROUP="${ENABLE_NESTED_GROUP}" \ | ||
| -DNESTED_GROUP_MODULE_DIR="${WITH_NESTED_GROUP_DIR}" \ |
eldenmoon
force-pushed
the
branch-4.1-nested-group-public
branch
from
72698ac to
307593f
Compare
eldenmoon
added a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Jun 22, 2026
Member
Author
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Member
Author
|
run buildall |
eldenmoon
force-pushed
the
branch-4.1-nested-group-public
branch
from
307593f to
a4dddd3
Compare
eldenmoon
added a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Jun 22, 2026
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE Regression Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick #9818