From b052df7b68323e4b6d83a31775df0eb030fabf16 Mon Sep 17 00:00:00 2001 From: hedger9487 Date: Wed, 26 Aug 2026 09:38:31 +0800 Subject: [PATCH] Fix TruncateTransform.satisfies_order_of for different widths (#3680) --- pyiceberg/transforms.py | 6 +----- tests/test_transforms.py | 8 ++++++++ 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/pyiceberg/transforms.py b/pyiceberg/transforms.py index 5e0027a829..b1e7c59716 100644 --- a/pyiceberg/transforms.py +++ b/pyiceberg/transforms.py @@ -896,11 +896,7 @@ def truncate_func(v: Any) -> Any: def satisfies_order_of(self, other: Transform[S, T]) -> bool: if self == other: return True - elif ( - isinstance(self.source_type, StringType) - and isinstance(other, TruncateTransform) - and isinstance(other.source_type, StringType) - ): + elif isinstance(other, TruncateTransform): return self.width >= other.width return False diff --git a/tests/test_transforms.py b/tests/test_transforms.py index c977fcea14..8645cfa4ca 100644 --- a/tests/test_transforms.py +++ b/tests/test_transforms.py @@ -513,6 +513,14 @@ def test_truncate_method(type_var: PrimitiveType, value: Any, expected_human_str assert truncate_transform.satisfies_order_of(truncate_transform) +def test_truncate_satisfies_order_of() -> None: + assert TruncateTransform(5).satisfies_order_of(TruncateTransform(3)) + assert TruncateTransform(5).satisfies_order_of(TruncateTransform(5)) + assert not TruncateTransform(3).satisfies_order_of(TruncateTransform(5)) + assert not TruncateTransform(5).satisfies_order_of(BucketTransform(5)) + assert not TruncateTransform(5).satisfies_order_of(IdentityTransform()) + + def test_unknown_transform() -> None: unknown_transform = UnknownTransform("unknown") # type: ignore assert str(unknown_transform) == str(eval(repr(unknown_transform)))