From 1d0a940c989baac3c7246b09e6211c723f2300c1 Mon Sep 17 00:00:00 2001 From: vishnuprakaz Date: Thu, 11 Jun 2026 16:28:37 +0530 Subject: [PATCH 1/3] API: Add tests for DateTimeUtil.microsToMillis --- .../test/java/org/apache/iceberg/util/TestDateTimeUtil.java | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/api/src/test/java/org/apache/iceberg/util/TestDateTimeUtil.java b/api/src/test/java/org/apache/iceberg/util/TestDateTimeUtil.java index 02ee8252d5f0..c6f169b8aa25 100644 --- a/api/src/test/java/org/apache/iceberg/util/TestDateTimeUtil.java +++ b/api/src/test/java/org/apache/iceberg/util/TestDateTimeUtil.java @@ -38,6 +38,12 @@ public void microsToNanos() { assertThat(DateTimeUtil.microsToNanos(-1510871468000001L)).isEqualTo(-1510871468000001000L); } + @Test + public void microsToMillis() { + assertThat(DateTimeUtil.microsToMillis(1510871468000001L)).isEqualTo(1510871468000L); + assertThat(DateTimeUtil.microsToMillis(-1510871468000001L)).isEqualTo(-1510871468001L); + } + @Test public void isoTimestampToNanos() { assertThat(DateTimeUtil.isoTimestampToNanos("2017-11-16T22:31:08.000001001")) From 0d75e95293b8e9c7cf6953d9b19af438a7abc0bd Mon Sep 17 00:00:00 2001 From: vishnuprakaz Date: Thu, 11 Jun 2026 17:56:30 +0530 Subject: [PATCH 2/3] Trigger CI re-run From 83ffa5d37d01e3aa2937a7bb186f19b98361ae7a Mon Sep 17 00:00:00 2001 From: vishnuprakaz Date: Fri, 12 Jun 2026 11:57:06 +0530 Subject: [PATCH 3/3] Move microsToMillis test above nanosToMicros --- .../org/apache/iceberg/util/TestDateTimeUtil.java | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/api/src/test/java/org/apache/iceberg/util/TestDateTimeUtil.java b/api/src/test/java/org/apache/iceberg/util/TestDateTimeUtil.java index c6f169b8aa25..c660124ba7b1 100644 --- a/api/src/test/java/org/apache/iceberg/util/TestDateTimeUtil.java +++ b/api/src/test/java/org/apache/iceberg/util/TestDateTimeUtil.java @@ -26,6 +26,12 @@ import org.junit.jupiter.api.Test; public class TestDateTimeUtil { + @Test + public void microsToMillis() { + assertThat(DateTimeUtil.microsToMillis(1510871468000001L)).isEqualTo(1510871468000L); + assertThat(DateTimeUtil.microsToMillis(-1510871468000001L)).isEqualTo(-1510871468001L); + } + @Test public void nanosToMicros() { assertThat(DateTimeUtil.nanosToMicros(1510871468000001001L)).isEqualTo(1510871468000001L); @@ -38,12 +44,6 @@ public void microsToNanos() { assertThat(DateTimeUtil.microsToNanos(-1510871468000001L)).isEqualTo(-1510871468000001000L); } - @Test - public void microsToMillis() { - assertThat(DateTimeUtil.microsToMillis(1510871468000001L)).isEqualTo(1510871468000L); - assertThat(DateTimeUtil.microsToMillis(-1510871468000001L)).isEqualTo(-1510871468001L); - } - @Test public void isoTimestampToNanos() { assertThat(DateTimeUtil.isoTimestampToNanos("2017-11-16T22:31:08.000001001"))